[instrumentation] Rename InspectorInstrumentation into CoreProbes

[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move probe instrumentation related files to core/probe.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2772613002
Cr-Commit-Position: refs/heads/master@{#460285}
Committed: https://chromium.googlesource.com/chromium/src/+/80b97517ddcc63d3d901bd63c8184ccd26ac223a

[alph, 2017-03-23 00:17:08]

Description was changed from

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move instrumentation related files to core/instrumentation.
Add alph@ and caseq@ to instrumentation OWNERS.

BUG=695625
==========

to

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move instrumentation related files to core/instrumentation.
Add alph@ and caseq@ to instrumentation OWNERS.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[alph, 2017-03-23 00:17:09]

Description was changed from

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move instrumentation related files to core/instrumentation.
Add alph@ and caseq@ to instrumentation OWNERS.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move instrumentation related files to core/instrumentation.
Add alph@ and caseq@ to instrumentation OWNERS.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[alph, 2017-03-23 00:18:00]

alph@chromium.org changed reviewers:
+ pfeldman@chromium.org

[alph, 2017-03-23 00:18:12]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 00:24:49]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[alph, 2017-03-23 20:34:47]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 20:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-03-23 22:43:52]

ptal. I updated the issue with a link to design doc.

[commit-bot: I haz the power, 2017-03-23 22:48:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:48:59]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-03-23 23:16:06]

On 2017/03/23 22:43:52, alph wrote:
> ptal. I updated the issue with a link to design doc.

Hi alph@,

Is there any chance to use different suffix for CodeProbes.idl? This isn't
actually an IDL file and this CL will cause the same problem as
https://codereview.chromium.org/2754763002/. If it's not feasible, could you
update bindings_tests.py too?

[alph, 2017-03-24 00:23:15]

On 2017/03/23 23:16:06, bashi (slow til Mar 23) wrote:
> On 2017/03/23 22:43:52, alph wrote:
> > ptal. I updated the issue with a link to design doc.
> 
> Hi alph@,
> 
> Is there any chance to use different suffix for CodeProbes.idl? This isn't
> actually an IDL file and this CL will cause the same problem as
> https://codereview.chromium.org/2754763002/. If it's not feasible, could you
> update bindings_tests.py too?

Hi bashi,
Sorry about the trouble. I fixed it.

[bashi, 2017-03-24 00:25:20]

On 2017/03/24 00:23:15, alph wrote:
> On 2017/03/23 23:16:06, bashi (slow til Mar 23) wrote:
> > On 2017/03/23 22:43:52, alph wrote:
> > > ptal. I updated the issue with a link to design doc.
> > 
> > Hi alph@,
> > 
> > Is there any chance to use different suffix for CodeProbes.idl? This isn't
> > actually an IDL file and this CL will cause the same problem as
> > https://codereview.chromium.org/2754763002/. If it's not feasible, could you
> > update bindings_tests.py too?
> 
> Hi bashi,
> Sorry about the trouble. I fixed it.

Thank you for the fix!

[pfeldman, 2017-03-24 23:03:35]

https://codereview.chromium.org/2772613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.h (right):

https://codereview.chromium.org/2772613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.h:151: Member<CoreProbesSink>
m_instrumentingAgents;
CoreProbeSink

https://codereview.chromium.org/2772613002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp (right):

https://codereview.chromium.org/2772613002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp:39: #include
"core/instrumentation/CoreProbes.h"
core/probe/CoreProbes.h

[pfeldman, 2017-03-24 23:39:16]

otherwise lgtm

[alph, 2017-03-25 00:55:59]

Description was changed from

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move instrumentation related files to core/instrumentation.
Add alph@ and caseq@ to instrumentation OWNERS.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move probe instrumentation related files to core/probe.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[alph, 2017-03-25 01:05:16]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-25 01:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2772613002/#ps80001
(title: "Add missing files.")

[commit-bot: I haz the power, 2017-03-25 01:05:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 01:27:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 01:27:38]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alph, 2017-03-25 07:04:57]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-25 07:04:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2772613002/#ps100001
(title: "fix link error")

[commit-bot: I haz the power, 2017-03-25 07:05:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 07:46:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 07:46:43]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[alph, 2017-03-25 19:33:48]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-25 19:33:51]

The CQ bit was unchecked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-25 19:33:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-03-25 19:34:00]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-25 19:34:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-25 20:15:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-25 20:15:06]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[alph, 2017-03-27 01:27:42]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-27 01:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 01:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 01:32:34]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[alph, 2017-03-27 05:48:36]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-27 05:48:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2772613002/#ps120001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-03-27 05:48:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:28:31]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[alph, 2017-03-28 18:59:35]

The CQ bit was checked by alph@chromium.org

[alph, 2017-03-28 18:59:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2772613002/#ps140001
(title: "fix typo")

[commit-bot: I haz the power, 2017-03-28 19:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 21:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 21:15:29]

CQ has no permission to schedule in bucket master.tryserver.chromium.linux

[alph, 2017-03-29 03:14:55]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 05:20:18]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490757295593630,
"parent_rev": "1ade7ad316d84cfceaf7980c4d14bd79aaea0ebc", "commit_rev":
"80b97517ddcc63d3d901bd63c8184ccd26ac223a"}

[commit-bot: I haz the power, 2017-03-29 05:21:55]

Description was changed from

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move probe instrumentation related files to core/probe.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[instrumentation] Rename InspectorInstrumentation into CoreProbes

Rename probe::InstrumentingAgents into probe::Sink
Move probe instrumentation related files to core/probe.

BUG=695625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2772613002
Cr-Commit-Position: refs/heads/master@{#460285}
Committed:
https://chromium.googlesource.com/chromium/src/+/80b97517ddcc63d3d901bd63c818...
==========

[commit-bot: I haz the power, 2017-03-29 05:21:58]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/80b97517ddcc63d3d901bd63c818...