Pass UIImage instead of gfx::Image in ContentSuggestions

Pass UIImage instead of gfx::Image in ContentSuggestions

The UI should have as much Objective-C primitive as possible.

BUG=694159
Review-Url: https://codereview.chromium.org/2772583005
Cr-Commit-Position: refs/heads/master@{#461420}
Committed: https://chromium.googlesource.com/chromium/src/+/3b0b9b5da27518bbc4f22915ed71eff935b7d3ce

[gambard, 2017-03-24 13:28:21]

gambard@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[gambard, 2017-03-24 13:28:22]

PTAL.

[stkhapugin, 2017-03-24 16:31:40]

not lgtm

https://codereview.chromium.org/2772583005/diff/1/ios/chrome/browser/content_...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2772583005/diff/1/ios/chrome/browser/content_...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:315:
callback(image.CopyUIImage());
This returns a retained UIImage. You need to use image() instead.

[gambard, 2017-03-28 07:22:28]

PTAL

https://codereview.chromium.org/2772583005/diff/1/ios/chrome/browser/content_...
File ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
(right):

https://codereview.chromium.org/2772583005/diff/1/ios/chrome/browser/content_...
ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm:315:
callback(image.CopyUIImage());
On 2017/03/24 16:31:40, stkhapugin wrote:
> This returns a retained UIImage. You need to use image() instead. 

Done.

[stkhapugin, 2017-04-03 13:23:45]

lgtm

[gambard, 2017-04-03 13:24:01]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-04-03 13:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 13:26:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 13:26:09]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[gambard, 2017-04-03 13:35:23]

The CQ bit was checked by gambard@chromium.org

[gambard, 2017-04-03 13:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org
Link to the patchset: https://codereview.chromium.org/2772583005/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-03 13:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 13:46:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491226523758140,
"parent_rev": "5631edf30355475e441788c1ef65e9a6ffba05dc", "commit_rev":
"3b0b9b5da27518bbc4f22915ed71eff935b7d3ce"}

[commit-bot: I haz the power, 2017-04-03 13:46:55]

Description was changed from

==========
Pass UIImage instead of gfx::Image in ContentSuggestions

The UI should have as much Objective-C primitive as possible.

BUG=694159
==========

to

==========
Pass UIImage instead of gfx::Image in ContentSuggestions

The UI should have as much Objective-C primitive as possible.

BUG=694159

Review-Url: https://codereview.chromium.org/2772583005
Cr-Commit-Position: refs/heads/master@{#461420}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b0b9b5da27518bbc4f22915ed71...
==========

[commit-bot: I haz the power, 2017-04-03 13:46:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3b0b9b5da27518bbc4f22915ed71...