Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2772583004: Fixed external wpt csp img-src/* tests. (Closed)

Created:
3 years, 9 months ago by andypaicu
Modified:
3 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed external wpt csp img-src/* tests. Fixed flaky test that caused the patch to need to be reverted Fixed the existing test Moved over some tests from http/test/security/contentSecurityPolicy Un-skipped the img-src folder This is a re-land of https://codereview.chromium.org/2763253002. BUG=694525 Review-Url: https://codereview.chromium.org/2772583004 Cr-Commit-Position: refs/heads/master@{#459751} Committed: https://chromium.googlesource.com/chromium/src/+/6d5c31a04772c4f0f398b7cb27e3ed7000bcbdf5

Patch Set 1 #

Patch Set 2 : Rebase-update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -127 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.html View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.html.sub.headers View 1 chunk +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-4_1.sub.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-full-host-wildcard-blocked.sub.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-host-partial-wildcard-allowed.sub.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-none-blocks.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-port-wildcard-allowed.sub.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-wildcard-allowed.html View 1 chunk +40 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-allowed.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-allowed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-alt-content.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-full-host-wildcard-fails.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-full-host-wildcard-fails-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
andypaicu
The other CL was reverted because of a flaky test. I've modified the test to ...
3 years, 9 months ago (2017-03-24 11:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772583004/1
3 years, 9 months ago (2017-03-24 13:11:36 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-24 13:11:37 UTC) #10
Mike West
LGTM
3 years, 9 months ago (2017-03-25 08:43:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772583004/1
3 years, 9 months ago (2017-03-27 06:49:57 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-27 08:05:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772583004/1
3 years, 9 months ago (2017-03-27 09:26:59 UTC) #18
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-27 09:33:29 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772583004/20001
3 years, 9 months ago (2017-03-27 09:56:15 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-27 11:08:51 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6d5c31a04772c4f0f398b7cb27e3...

Powered by Google App Engine
This is Rietveld 408576698