chromeos: Improve ProxyResolutionServiceProvider testing.

chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc

Index: chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc
diff --git a/chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc b/chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc
index c853ace4322f523abe75d360d9f3f006d74324f6..e9c6ddd42d9ac82759f85e9f67497a62ef6db10c 100644
--- a/chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc
+++ b/chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.cc
@@ -5,6 +5,8 @@
 #include "chrome/browser/chromeos/dbus/chrome_proxy_resolver_delegate.h"
 
 #include "chrome/browser/profiles/profile_manager.h"
+#include "net/log/net_log_with_source.h"
+#include "net/proxy/proxy_service.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace chromeos {
@@ -19,4 +21,14 @@ ChromeProxyResolverDelegate::GetRequestContext() {
   return profile->GetRequestContext();
 }
 
+int ChromeProxyResolverDelegate::ResolveProxy(
+    net::ProxyService* proxy_service,
+    const GURL& url,
+    net::ProxyInfo* results,

[James Cook, 2017/03/22 23:16:27]

DCHECK this?

[Daniel Erat, 2017/03/22 23:23:40]

i wasn't sure if that was keeping in the spirit of this being a shim, but sure.
:-)

+    const net::CompletionCallback& callback) {
+  DCHECK(proxy_service);
+  return proxy_service->ResolveProxy(url, std::string(), results, callback,

[Daniel Erat, 2017/03/22 22:58:56]

i don't love adding tiny shims like this that just call a method on an object
passed to them, but net::ProxyService seems pretty un-stubbable. :-(

+                                     nullptr, nullptr, net::NetLogWithSource());
+}
+
 }  // namespace chromeos