Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 2772553002: DevTools: copy console tests to /Source/devtools/tests/ (Closed)

Created:
3 years, 9 months ago by chenwilliam
Modified:
3 years, 9 months ago
Reviewers:
dgozman, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: copy console tests to /Source/devtools/tests/ While I'm ironing out the process for running tests locally & trybots from the new test directory, I'd like to copy these tests. I'll delete them from the original location later once this is stable. This does mean that if these tests / expectations change, they'll need to be updated in two locations, but I believe these are stable and shouldn't change much in the short-term. BUG=660477 Review-Url: https://codereview.chromium.org/2772553002 Cr-Commit-Position: refs/heads/master@{#459331} Committed: https://chromium.googlesource.com/chromium/src/+/1f10d44710039f6b1b2437cfc2819295659ff7d0

Patch Set 1 #

Patch Set 2 : w/ docs & moves #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -115 lines) Patch
A third_party/WebKit/Source/devtools/tests/README.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/devtools/tests/TestExpectations View 1 1 chunk +0 lines, -116 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/compatibility/TestExpectations View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-assert.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-assert-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-clear.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-clear-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-clear-function.html View 1 1 chunk +47 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-clear-function-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-command-copy.html View 1 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/console/console-command-copy-expected.txt View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
chenwilliam
ptal
3 years, 9 months ago (2017-03-22 21:13:07 UTC) #3
luoe
These seem like good candidates. If this is the first instance of Source/devtools/tests, I would ...
3 years, 9 months ago (2017-03-22 23:37:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772553002/20001
3 years, 9 months ago (2017-03-23 22:10:50 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 9 months ago (2017-03-23 22:10:51 UTC) #9
chenwilliam
@dgozman, ptal
3 years, 9 months ago (2017-03-23 23:59:17 UTC) #11
dgozman
lgtm
3 years, 9 months ago (2017-03-24 00:29:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772553002/20001
3 years, 9 months ago (2017-03-24 00:33:51 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 01:37:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f10d44710039f6b1b2437cfc281...

Powered by Google App Engine
This is Rietveld 408576698