Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2772543002: Fix incorrect parameter name for useCounterDocument in CSSParserContext (Closed)

Created:
3 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 9 months ago
Reviewers:
dcheng
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect parameter name for useCounterDocument in CSSParserContext R=dcheng@chromium.org BUG= Review-Url: https://codereview.chromium.org/2772543002 Cr-Commit-Position: refs/heads/master@{#458920} Committed: https://chromium.googlesource.com/chromium/src/+/1139825719f0479bc40151d88e8bb416bafad5eb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp View 5 chunks +12 lines, -12 lines 2 comments Download

Messages

Total messages: 11 (6 generated)
jochen (gone - plz use gerrit)
3 years, 9 months ago (2017-03-22 21:08:03 UTC) #1
dcheng
LGTM https://codereview.chromium.org/2772543002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp File third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp (right): https://codereview.chromium.org/2772543002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp#newcode35 third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp:35: const Document* useCounterDocument) { Personally I'd just call ...
3 years, 9 months ago (2017-03-22 21:09:59 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/2772543002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp File third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp (right): https://codereview.chromium.org/2772543002/diff/1/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp#newcode54 third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp:54: const Document* useCounterDocument) { this would collide here...
3 years, 9 months ago (2017-03-22 21:10:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772543002/1
3 years, 9 months ago (2017-03-22 21:11:08 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 23:09:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1139825719f0479bc40151d88e8b...

Powered by Google App Engine
This is Rietveld 408576698