Disable permissions embargo for plugins.

chrome/browser/permissions/permission_decision_auto_blocker.cc

Index: chrome/browser/permissions/permission_decision_auto_blocker.cc
diff --git a/chrome/browser/permissions/permission_decision_auto_blocker.cc b/chrome/browser/permissions/permission_decision_auto_blocker.cc
index 4dcc5fa94e37834bcfe3a68b5c09ad93c9e9c56f..3e9db0459135eed89f624672c55b0f5cf9bcf157 100644
--- a/chrome/browser/permissions/permission_decision_auto_blocker.cc
+++ b/chrome/browser/permissions/permission_decision_auto_blocker.cc
@@ -280,6 +280,7 @@ bool PermissionDecisionAutoBlocker::RecordDismissAndEmbargo(
       url, permission, kPromptDismissCountKey, profile_);
 
   if (base::FeatureList::IsEnabled(features::kBlockPromptsIfDismissedOften) &&
+      permission != CONTENT_SETTINGS_TYPE_PLUGINS &&

[benwells, 2017/03/23 04:39:25]

I think it would be cleaner to place this in PermissionContext. That is, add
PermissionContextBase::AutoBlockAfterRepeatedDismissal(), and override that for
FlashPermissionContextBase.

Would that work?

[dominickn, 2017/03/23 04:45:22]

That would mean also placing the logic in PermissionQueueController (which has a
separate call to RecordDismissAndEmbargo), which is why I chose to put it in
here. How strongly do you feel about it?

The other downside is that we would no longer correctly record repeated
dismissals for permissions which opt out of auto blocking (unless we pass a
should_block variable into RecordDismissAndEmbargo since this method also
records the dismissal event into content settings). What are your thoughts on
that?

       current_dismissal_count >= g_prompt_dismissals_before_block) {
     PlaceUnderEmbargo(url, permission, kPermissionDismissalEmbargoKey);
     return true;