Disable permissions embargo for plugins.

chrome/browser/permissions/permission_decision_auto_blocker.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_decision_auto_blocker.h"
 
 #include <memory>
 
 #include "base/feature_list.h"
 #include "base/memory/ptr_util.h"
@@ skipping 262 matching lines @@
   return GetActionCount(url, permission, kPromptIgnoreCountKey, profile_);
 }
 
 bool PermissionDecisionAutoBlocker::RecordDismissAndEmbargo(
     const GURL& url,
     ContentSettingsType permission) {
   int current_dismissal_count = RecordActionInWebsiteSettings(
       url, permission, kPromptDismissCountKey, profile_);
 
   if (base::FeatureList::IsEnabled(features::kBlockPromptsIfDismissedOften) &&
+      permission != CONTENT_SETTINGS_TYPE_PLUGINS &&

[benwells, 2017/03/23 04:39:25]

I think it would be cleaner to place this in PermissionContext. That is, add
PermissionContextBase::AutoBlockAfterRepeatedDismissal(), and override that for
FlashPermissionContextBase.

Would that work?

[dominickn, 2017/03/23 04:45:22]

That would mean also placing the logic in PermissionQueueController (which has a
separate call to RecordDismissAndEmbargo), which is why I chose to put it in
here. How strongly do you feel about it?

The other downside is that we would no longer correctly record repeated
dismissals for permissions which opt out of auto blocking (unless we pass a
should_block variable into RecordDismissAndEmbargo since this method also
records the dismissal event into content settings). What are your thoughts on
that?

       current_dismissal_count >= g_prompt_dismissals_before_block) {
     PlaceUnderEmbargo(url, permission, kPermissionDismissalEmbargoKey);
     return true;
   }
   return false;
 }
 
 int PermissionDecisionAutoBlocker::RecordIgnore(
     const GURL& url,
     ContentSettingsType permission) {
@@ skipping 70 matching lines @@
         scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager> db_manager,
         int timeout) {
   db_manager_ = db_manager;
   safe_browsing_timeout_ = timeout;
 }
 
 void PermissionDecisionAutoBlocker::SetClockForTesting(
     std::unique_ptr<base::Clock> clock) {
   clock_ = std::move(clock);
 }