Makes AshTestHelper shutdown ChromeOS NetworkHandler

Makes AshTestHelper shutdown ChromeOS NetworkHandler

Classic ash unittests don't run with the NetworkHandler running. To
run with the NetworkHandler triggers additional items on the tray,
which tests are not setup to deal correctly with.

BUG=695751, 696769
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2772513003
Cr-Commit-Position: refs/heads/master@{#458927}
Committed: https://chromium.googlesource.com/chromium/src/+/eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69

[sky, 2017-03-22 21:59:37]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:00:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-22 22:27:22]

https://codereview.chromium.org/2772513003/diff/1/ash/test/ash_test_helper.cc
File ash/test/ash_test_helper.cc (right):

https://codereview.chromium.org/2772513003/diff/1/ash/test/ash_test_helper.cc...
ash/test/ash_test_helper.cc:307: chromeos::NetworkHandler::Shutdown();
Rather than doing this, how about passing a "for_test" boolean to
WindowManagerApplication and skipping the initialization?

[James Cook, 2017-03-22 22:27:41]

On 2017/03/22 22:27:22, James Cook wrote:
> https://codereview.chromium.org/2772513003/diff/1/ash/test/ash_test_helper.cc
> File ash/test/ash_test_helper.cc (right):
> 
>
https://codereview.chromium.org/2772513003/diff/1/ash/test/ash_test_helper.cc...
> ash/test/ash_test_helper.cc:307: chromeos::NetworkHandler::Shutdown();
> Rather than doing this, how about passing a "for_test" boolean to
> WindowManagerApplication and skipping the initialization?

Or a "initialize_network_handler" boolean.

[sky, 2017-03-22 22:41:23]

I went with the boolean indicating if NetworkHandler should be initialized.

[sky, 2017-03-22 22:41:28]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 22:42:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-22 22:42:42]

LGTM

[sky, 2017-03-22 22:46:22]

The CQ bit was unchecked by sky@chromium.org

[sky, 2017-03-22 22:46:26]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:24:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490222786864040,
"parent_rev": "130aefc5b0d01ced8a2dc0b17db8179d422ac526", "commit_rev":
"eeccd7ee07f0c25c2de9b9ab4c176ac0b3441e69"}

[commit-bot: I haz the power, 2017-03-22 23:25:09]

Description was changed from

==========
Makes AshTestHelper shutdown ChromeOS NetworkHandler

Classic ash unittests don't run with the NetworkHandler running. To
run with the NetworkHandler triggers additional items on the tray,
which tests are not setup to deal correctly with.

BUG=695751,696769
TEST=test only changes
R=jamescook@chromium.org
==========

to

==========
Makes AshTestHelper shutdown ChromeOS NetworkHandler

Classic ash unittests don't run with the NetworkHandler running. To
run with the NetworkHandler triggers additional items on the tray,
which tests are not setup to deal correctly with.

BUG=695751,696769
TEST=test only changes
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2772513003
Cr-Commit-Position: refs/heads/master@{#458927}
Committed:
https://chromium.googlesource.com/chromium/src/+/eeccd7ee07f0c25c2de9b9ab4c17...
==========

[commit-bot: I haz the power, 2017-03-22 23:25:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eeccd7ee07f0c25c2de9b9ab4c17...