DOM: Fix a regression of :first-child and :last-child invalidation

CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child and
:last-child invalidation because the timing of ContainerNode::childrenChanged was
slightly changed for multiple nodes insertion.
 Before: childrenChanged was called on every node insertion
 After: childrenChanged was called after inserting all nodes

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
Review-Url: https://codereview.chromium.org/2772463004
Cr-Commit-Position: refs/heads/master@{#459023}
Committed: https://chromium.googlesource.com/chromium/src/+/e89e9ca08e4abca7bf13d7424434b301caf5b4a5

[tkent, 2017-03-23 02:43:38]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 02:43:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-23 02:44:12]

Description was changed from

==========
DOM: Fix a regression of :first-child and :last-child invalidation

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

BUG=702104
==========

[commit-bot: I haz the power, 2017-03-23 03:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 03:02:21]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tkent, 2017-03-23 04:07:52]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

Change the definition of ChildrenChanged::

ContainerNode::checkForSiblingStyleChanges

BUG=702104
==========

[tkent, 2017-03-23 04:11:48]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

Change the definition of ChildrenChanged::

ContainerNode::checkForSiblingStyleChanges

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation


https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

[tkent, 2017-03-23 04:11:57]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation


https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

[tkent, 2017-03-23 04:12:10]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

[tkent, 2017-03-23 04:12:44]

tkent@chromium.org changed reviewers:
+ hayato@chromium.org

[tkent, 2017-03-23 04:12:44]

hayato@, would you review this please?

[hayato, 2017-03-23 05:05:22]

lgtm

[tkent, 2017-03-23 05:09:20]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.
 Before: childrenChanged was called on every node insertion
 After: childrenChanged was called after inserting all nodes

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

[tkent, 2017-03-23 05:09:26]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-23 05:09:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 05:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 05:26:00]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tkent, 2017-03-23 05:50:09]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-23 05:50:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 06:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 06:05:01]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tkent, 2017-03-23 07:39:20]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-23 07:39:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 08:08:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490254760694670, "parent_rev":
"b055586989fbca2696edc7e849c995bf05e0f0c1", "commit_rev":
"e89e9ca08e4abca7bf13d7424434b301caf5b4a5"}

[commit-bot: I haz the power, 2017-03-23 08:09:31]

Description was changed from

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.
 Before: childrenChanged was called on every node insertion
 After: childrenChanged was called after inserting all nodes

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104
==========

to

==========
CSS Selector: Fix a regression of :first-child and :last-child invalidation

https://codereview.chromium.org/2306323002 caused a regression of :first-child
and
:last-child invalidation because the timing of ContainerNode::childrenChanged
was
slightly changed for multiple nodes insertion.
 Before: childrenChanged was called on every node insertion
 After: childrenChanged was called after inserting all nodes

This CL changes the definition of ChildrenChanged::siblingBeforeChange and
siblingAfterChange so that they always point existing nodes before insertion
operations. It fixes the behavior of ContainerNode::checkForSiblingStyleChanges,
which is called from Element::childrenChanged and ShadowRoot::childrenChanged.
siblingBeforeChange and siblingAfterChange are used only by
checkForSiblingStyleChanges.  So this definition change is safe.

BUG=702104

Review-Url: https://codereview.chromium.org/2772463004
Cr-Commit-Position: refs/heads/master@{#459023}
Committed:
https://chromium.googlesource.com/chromium/src/+/e89e9ca08e4abca7bf13d7424434...
==========

[commit-bot: I haz the power, 2017-03-23 08:09:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e89e9ca08e4abca7bf13d7424434...