Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2772453003: Keep WebBluetooth chooser open when permission prompt is shown on Android (Closed)

Created:
3 years, 9 months ago by juncai
Modified:
3 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep WebBluetooth chooser open when permission prompt is shown on Android On Android, when WebBluetooth chooser is shown and needs to open permission prompt, the chooser will be closed. This CL uses similar idea as: https://codereview.chromium.org/2622123002/ to keep the chooser open when permission prompt is shown. BUG=661862 Review-Url: https://codereview.chromium.org/2772453003 Cr-Commit-Position: refs/heads/master@{#459197} Committed: https://chromium.googlesource.com/chromium/src/+/729ec70ac51077fad0c36dc88d8e8a425eb77032

Patch Set 1 : keep WebBluetooth chooser open when permission prompt is shown on Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java View 3 chunks +19 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
juncai
Please take a look.
3 years, 9 months ago (2017-03-23 00:49:15 UTC) #7
Ted C
lgtm
3 years, 9 months ago (2017-03-23 19:14:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772453003/1
3 years, 9 months ago (2017-03-23 20:11:58 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 20:19:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/729ec70ac51077fad0c36dc88d8e...

Powered by Google App Engine
This is Rietveld 408576698