Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2772433002: Clarify in dev_compiler docs the reason for the angular whitelist hack (Closed)

Created:
3 years, 9 months ago by kevmoo
Modified:
3 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 chunk +11 lines, -13 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kevmoo
...you asked ;-)
3 years, 9 months ago (2017-03-22 18:09:56 UTC) #2
Jennifer Messerly
lgtm, thanks Kevin!
3 years, 9 months ago (2017-03-22 18:21:19 UTC) #3
kevmoo
3 years, 9 months ago (2017-03-22 18:36:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2340c8f6df17eb38e51e0f7a2edbbc73f9055317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698