Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: pkg/dev_compiler/lib/src/compiler/compiler.dart

Issue 2772433002: Clarify in dev_compiler docs the reason for the angular whitelist hack (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index 0c61b7571d19fd95e10be0132009a4a19303a5b6..e90d37259c18e5796344975881da371aebaac522 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -266,6 +266,8 @@ class CompilerOptions {
/// Hoist types in type tests
final bool hoistTypeTests;
+ // TODO(kevmoo): Remove once https://github.com/dart-lang/sdk/issues/27255
+ // is fixed.
final bool useAngular2Whitelist;
/// Enable ES6 destructuring of named parameters. Off by default.
@@ -375,6 +377,8 @@ class CompilerOptions {
help: 'Name types used in type tests', defaultsTo: true, hide: hide)
..addFlag('hoist-type-tests',
help: 'Hoist types used in type tests', defaultsTo: true, hide: hide)
+ // TODO(kevmoo): Remove once https://github.com/dart-lang/sdk/issues/27255
+ // is fixed.
..addFlag('unsafe-angular2-whitelist', defaultsTo: false, hide: hide)
..addOption('bazel-mapping',
help:
« no previous file with comments | « pkg/dev_compiler/lib/src/compiler/code_generator.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698