Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py

Issue 2772373003: Initialize run_webkit_tests's image-first-tests flag from file (Closed)
Patch Set: fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
index 8fa61f587434c5f0257752a26ecb66e26a80a926..0a09e50d71b242ae360cb90b3758da7cbe8a1f22 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py
@@ -1041,6 +1041,19 @@ class RunTest(unittest.TestCase, StreamTestingMixin):
'Regressions: Unexpected missing results (1)\n'
' failures/unexpected/missing_image.html [ Missing ]\n\n'))
+ def test_image_first_flag_initialized_from_file(self):
+ host = MockHost()
+ image_first_tests_filename = test.LAYOUT_TEST_DIR + '/ImageFirstTests'
+ image_first_folder1 = 'fooFolder1'
+ image_first_folder2 = 'fooFolder2'
+ host.filesystem.write_text_file(image_first_tests_filename, '%s\n%s' % (image_first_folder1, image_first_folder2))
+
+ options, args = parse_args()
+ port_obj = host.port_factory.get(options.platform, options)
+
+ run_webkit_tests.run(port_obj, options, args, StringIO.StringIO(), StringIO.StringIO())
+ self.assertListEqual(options.image_first_tests, [image_first_folder1, image_first_folder2])
+
class EndToEndTest(unittest.TestCase):
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698