third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py - Issue 2772373003: Initialize run_webkit_tests's image-first-tests flag from file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2772373003: Initialize run_webkit_tests's image-first-tests flag from file (Closed)

Patch Set: fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/OWNERS ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

index f999f5c9c19125cc61b0e1f10492326fa28b2d1f..0e87c72a83067ff250c8ad34404017e3aa81e497 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -555,6 +555,12 @@ def _set_up_derived_options(port, options, args):

if not options.seed:

options.seed = port.host.time()

+ if not options.image_first_tests:

+ image_first_tests_path = port.host.filesystem.join(port.layout_tests_dir(), 'ImageFirstTests')

+ if port.host.filesystem.exists(image_first_tests_path):

+ contents = port.host.filesystem.read_text_file(image_first_tests_path)

+ options.image_first_tests.extend(line for line in contents.splitlines(False) if line)

def _run_tests(port, options, args, printer):

_set_up_derived_options(port, options, args)