Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2772363002:
Separate function decoding counter into asm and wasm counters. (Closed)
DescriptionSeparate function decoding counter into asm and wasm counters.
Currently, V8 uses the same counter to collect decoding time for both asm.js and
WASM. This separates the function decoding counter into two separate counters,
and then uses the appropriate counter when decoding a module.
BUG=chromium:704922
R=bbudge@chromium.org,bradnelson@chromium.org
Review-Url: https://codereview.chromium.org/2772363002
Cr-Commit-Position: refs/heads/master@{#44197}
Committed: https://chromium.googlesource.com/v8/v8/+/7d4cb943036f18bb8a54c239ffe1d5a8a434b584
Patch Set 1 #Patch Set 2 : Create dummy module environment for DecodeWasmFunction test. #
Total comments: 1
Messages
Total messages: 31 (25 generated)
Description was changed from ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 ========== to ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 ==========
kschimpf@chromium.org changed reviewers: + bbudge@google.com, bradnelson@chromium.org
Description was changed from ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 ========== to ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org ==========
kschimpf@chromium.org changed reviewers: + bbudge@chromium.org - bbudge@google.com
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
lgtm
The CQ bit was checked by kschimpf@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
kschimpf@google.com changed reviewers: + kschimpf@google.com
https://codereview.chromium.org/2772363002/diff/20001/test/unittests/wasm/mod... File test/unittests/wasm/module-decoder-unittest.cc (right): https://codereview.chromium.org/2772363002/diff/20001/test/unittests/wasm/mod... test/unittests/wasm/module-decoder-unittest.cc:922: class WasmFunctionVerifyTest : public TestWithIsolateAndZone { Added class fields to implement a dummy instance of ModuleBytesEnv for function DecodeWasmFunction below.
The CQ bit was checked by kschimpf@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org, bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2772363002/#ps20001 (title: "Create dummy module environment for DecodeWasmFunction test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490711162185040,
"parent_rev": "e3c484dc8d7535073bd9c851c8d2bd8587034bd3", "commit_rev":
"7d4cb943036f18bb8a54c239ffe1d5a8a434b584"}
Message was sent while issue was closed.
Description was changed from ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org ========== to ========== Separate function decoding counter into asm and wasm counters. Currently, V8 uses the same counter to collect decoding time for both asm.js and WASM. This separates the function decoding counter into two separate counters, and then uses the appropriate counter when decoding a module. BUG=chromium:704922 R=bbudge@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2772363002 Cr-Commit-Position: refs/heads/master@{#44197} Committed: https://chromium.googlesource.com/v8/v8/+/7d4cb943036f18bb8a54c239ffe1d5a8a43... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/7d4cb943036f18bb8a54c239ffe1d5a8a43... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
