Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2772323005: node-set($x), when $x is empty, should not halt XSLT processing (Closed)

Created:
3 years, 8 months ago by Oliver Chang
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

node-set($x), when $x is empty, should not halt XSLT processing node-set is polymorphic; if called with a string, it returns a node-set containing a text node with that content. The libxslt roll in r425586 broke this behavior because Blink's fork of the node-set extension returned a text node without an owner document. Fix that. BUG=689977 Review-Url: https://codereview.chromium.org/2750943004 Cr-Commit-Position: refs/heads/master@{#457692} (cherry picked from commit 3f6e482b7f13c1fc5bd68227321ef6da0ddf9937) Review-Url: https://codereview.chromium.org/2772323005 . Cr-Commit-Position: refs/branch-heads/3029@{#452} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/99ead7d1564d35a70799b7ee4c3821053fb3985c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/fast/xsl/xslt-node-set-empty.html View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTExtensions.cpp View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Oliver Chang
3 years, 8 months ago (2017-03-28 16:45:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99ead7d1564d35a70799b7ee4c3821053fb3985c.

Powered by Google App Engine
This is Rietveld 408576698