Make url_request_context dumps include context names

base/trace_event/memory_infra_background_whitelist.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_infra_background_whitelist.h"
 
 #include <ctype.h>
 #include <string.h>
 
 #include <string>
@@ skipping 51 matching lines @@
     "malloc",
     "malloc/allocated_objects",
     "malloc/metadata_fragmentation_caches",
     "net/http_network_session_0x?",
     "net/http_network_session_0x?/quic_stream_factory",
     "net/http_network_session_0x?/socket_pool",
     "net/http_network_session_0x?/spdy_session_pool",
     "net/http_network_session_0x?/stream_factory",
     "net/sdch_manager_0x?",
     "net/ssl_session_cache",
-    "net/url_request_context_0x?",
-    "net/url_request_context_0x?/http_cache",
-    "net/url_request_context_0x?/http_network_session",
-    "net/url_request_context_0x?/sdch_manager",
+    "net/url_request_context",
+    "net/url_request_context/%s",
+    "net/url_request_context/%s/0x?",
+    "net/url_request_context/%s/0x?/http_cache",
+    "net/url_request_context/%s/0x?/http_network_session",
+    "net/url_request_context/%s/0x?/sdch_manager",
     "web_cache/Image_resources",
     "web_cache/CSS stylesheet_resources",
     "web_cache/Script_resources",
     "web_cache/XSL stylesheet_resources",
     "web_cache/Font_resources",
     "web_cache/Other_resources",
     "partition_alloc/allocated_objects",
     "partition_alloc/partitions",
     "partition_alloc/partitions/array_buffer",
     "partition_alloc/partitions/buffer",
@@ skipping 85 matching lines @@
     parsing_hex = false;
     if (i + 1 < length && name[i] == '0' && name[i + 1] == 'x') {
       parsing_hex = true;
       stripped_str.append("0x?");
       ++i;
     } else {
       stripped_str.push_back(name[i]);
     }
   }
 
+  std::string url_request_context_prefix = "url_request_context/";
+  size_t pos = stripped_str.find(url_request_context_prefix);
+  if (pos != std::string::npos) {
+    size_t replace_start = pos + url_request_context_prefix.length();
+    size_t replace_end = stripped_str.find('\\', replace_start);
+    if (replace_end == std::string::npos)
+      replace_end = stripped_str.length();
+    stripped_str.replace(replace_start, replace_end - pos, "%s");

[ssid, 2017/03/27 23:02:34]

No this is exactly what we are trying to avoid in this file. The reason why we
whitelist is to avoid reporting PII data of the users. At some point in future
if you decide to make the "name" of url_request as the url name, then this would
end up uploading the url names which is a violation of the user privacy.
The original patch did it correctly with all the possible strings listed here. 
Also please look at the nit i added later:
https://codereview.chromium.org/2772283003/diff/1/base/trace_event/memory_inf...

The issue with "main" and "main_media" can be solved by adding "main/" and
"main_media/" I guess?

[xunjieli, 2017/03/28 01:04:56]

Done. 

Just to clarify: URLRequestContext is the thing that makes URLRequests. The
Context won't ever have a url attached to it.  

+  }
+
   for (size_t i = 0; g_allocator_dump_name_whitelist[i] != nullptr; ++i) {
     if (stripped_str == g_allocator_dump_name_whitelist[i]) {
       return true;
     }
   }
   return false;
 }
 
 void SetDumpProviderWhitelistForTesting(const char* const* list) {
   g_dump_provider_whitelist = list;
 }
 
 void SetAllocatorDumpNameWhitelistForTesting(const char* const* list) {
   g_allocator_dump_name_whitelist = list;
 }
 
 }  // namespace trace_event
 }  // namespace base