Make url_request_context dumps include context names

base/trace_event/memory_infra_background_whitelist.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_infra_background_whitelist.h"
 
 #include <ctype.h>
 #include <string.h>
 
 #include <string>
 
+#include "base/strings/string_util.h"
+
 namespace base {
 namespace trace_event {
 namespace {
 
 // The names of dump providers whitelisted for background tracing. Dump
 // providers can be added here only if the background mode dump has very
 // less performance and memory overhead.
 const char* const kDumpProviderWhitelist[] = {
     "android::ResourceManagerImpl",
     "BlinkGC",
@@ skipping 40 matching lines @@
     "malloc",
     "malloc/allocated_objects",
     "malloc/metadata_fragmentation_caches",
     "net/http_network_session_0x?",
     "net/http_network_session_0x?/quic_stream_factory",
     "net/http_network_session_0x?/socket_pool",
     "net/http_network_session_0x?/spdy_session_pool",
     "net/http_network_session_0x?/stream_factory",
     "net/sdch_manager_0x?",
     "net/ssl_session_cache",
-    "net/url_request_context_0x?",
-    "net/url_request_context_0x?/http_cache",
-    "net/url_request_context_0x?/http_network_session",
-    "net/url_request_context_0x?/sdch_manager",
+    "net/url_request_context",
+    "net/url_request_context/%s",
+    "net/url_request_context/%s/0x?",

[ssid, 2017/03/27 18:43:15]

I'd say just add all the strings here instead of stripping string of the known
types.
Other providers just list them here. Maybe worth changing this pattern, but for
this cl lets be consistent.

[xunjieli, 2017/03/27 19:24:55]

Done. Though it feels a bit verbose to list all the permutations.

[ssid, 2017/03/27 20:15:11]

Ahh, sorry I see why you did this now. I thought it would add only 6 strings
here. missed the combinations.

[xunjieli, 2017/03/27 20:27:14]

Done.

+    "net/url_request_context/%s/0x?/http_cache",
+    "net/url_request_context/%s/0x?/http_network_session",
+    "net/url_request_context/%s/0x?/sdch_manager",
     "web_cache/Image_resources",
     "web_cache/CSS stylesheet_resources",
     "web_cache/Script_resources",
     "web_cache/XSL stylesheet_resources",
     "web_cache/Font_resources",
     "web_cache/Other_resources",
     "partition_alloc/allocated_objects",
     "partition_alloc/partitions",
     "partition_alloc/partitions/array_buffer",
     "partition_alloc/partitions/buffer",
@@ skipping 85 matching lines @@
     parsing_hex = false;
     if (i + 1 < length && name[i] == '0' && name[i + 1] == 'x') {
       parsing_hex = true;
       stripped_str.append("0x?");
       ++i;
     } else {
       stripped_str.push_back(name[i]);
     }
   }
 
+  std::string url_request_context_prefix = "url_request_context/";
+  size_t pos = stripped_str.find(url_request_context_prefix);
+  if (pos != std::string::npos) {
+    const std::string names[] = {"system", "proxy",      "app_request",

[ssid, 2017/03/27 20:26:02]

nit: /s/std::string/const char* const/
s/names/kRequestNames/

[xunjieli, 2017/03/28 01:04:56]

Done.

+                                 "main",   "extensions", "safe_browsing",
+                                 "unknown"};
+    for (const auto& name : names) {
+      base::ReplaceSubstringsAfterOffset(
+          &stripped_str, pos + url_request_context_prefix.length(), name, "%s");
+    }
+  }
+
   for (size_t i = 0; g_allocator_dump_name_whitelist[i] != nullptr; ++i) {
     if (stripped_str == g_allocator_dump_name_whitelist[i]) {
       return true;
     }
   }
   return false;
 }
 
 void SetDumpProviderWhitelistForTesting(const char* const* list) {
   g_dump_provider_whitelist = list;
 }
 
 void SetAllocatorDumpNameWhitelistForTesting(const char* const* list) {
   g_allocator_dump_name_whitelist = list;
 }
 
 }  // namespace trace_event
 }  // namespace base