EXPERIMENT Make toPositionInFlatTree() to return null for DOM position not in flat tree

patch from issue 2729313002 at patchset 40001 (http://crrev.com/2729313002#ps40001)

Experiment to proceed patch[1]


[1] http://crrev.com/2729313002 BLOCKED Prune layout update calls from Editor::*appliedEditing

Editor used to update layout after applying commands for setting
frame selection. Now that setting frame selection no longer requires
clean layout, this patch removes these layout update calls.

BUG=590369
TEST=n/a; no behavior change

[yosin_UTC9, 2017-03-27 09:26:58]

Description was changed from

==========
2017-03-27T18:24:23

2017-03-27T18:20:56


BLOCKED Prune layout update calls from Editor::*appliedEditing

Editor used to update layout after applying commands for setting
frame selection. Now that setting frame selection no longer requires
clean layout, this patch removes these layout update calls.

BUG=590369
TEST=n/a; no behavior change

patch from issue 2729313002 at patchset 40001
(http://crrev.com/2729313002#ps40001)
==========

to

==========
patch from issue 2729313002 at patchset 40001
(http://crrev.com/2729313002#ps40001)

Experiment to proceed patch[1]


[1] http://crrev.com/2729313002 BLOCKED Prune layout update calls from
Editor::*appliedEditing

Editor used to update layout after applying commands for setting
frame selection. Now that setting frame selection no longer requires
clean layout, this patch removes these layout update calls.

BUG=590369
TEST=n/a; no behavior change
==========

[yosin_UTC9, 2017-03-27 09:30:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 09:30:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 10:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 10:57:05]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-03-27 18:17:45]

xiaochengh@chromium.org changed reviewers:
+ xiaochengh@chromium.org

[Xiaocheng, 2017-03-27 18:17:46]

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionEditor.cpp (right):

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionEditor.cpp:395:
m_cachedVisibleSelectionInFlatTree = createVisibleSelection(builder.build());
Is it fine if the cached VS and VSInFlatTree have different types (e.g., VS is
range but VSInFlatTree is Caret)?

[yosin_UTC9, 2017-03-29 03:20:21]

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionEditor.cpp (right):

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionEditor.cpp:395:
m_cachedVisibleSelectionInFlatTree = createVisibleSelection(builder.build());
On 2017/03/27 at 18:17:45, Xiaocheng wrote:
> Is it fine if the cached VS and VSInFlatTree have different types (e.g., VS is
range but VSInFlatTree is Caret)?

So far, we did adjustment in [1] which removed adjustment function. However, it
doesn't handle this case.
We want to have smarter adjustment, e.g. move a position before shadow host,
etc.

Since we're rewriting selection paint adjustment for layout NG, this case should
be handle there.

[1] http://crrrev.com/2706003002: Get rid of unused functions
SelectionAdjuster::adjustSelectionIn{DOM,Flat}Tree

[Xiaocheng, 2017-03-29 23:56:41]

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/SelectionEditor.cpp (right):

https://codereview.chromium.org/2772233002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/SelectionEditor.cpp:395:
m_cachedVisibleSelectionInFlatTree = createVisibleSelection(builder.build());
On 2017/03/29 at 03:20:21, yosin_UTC9 wrote:
> On 2017/03/27 at 18:17:45, Xiaocheng wrote:
> > Is it fine if the cached VS and VSInFlatTree have different types (e.g., VS
is range but VSInFlatTree is Caret)?
> 
> So far, we did adjustment in [1] which removed adjustment function. However,
it doesn't handle this case.
> We want to have smarter adjustment, e.g. move a position before shadow host,
etc.
> 
> Since we're rewriting selection paint adjustment for layout NG, this case
should be handle there.
> 
> [1] http://crrrev.com/2706003002: Get rid of unused functions
SelectionAdjuster::adjustSelectionIn{DOM,Flat}Tree

OK. So the type mismatch currently exists, and will be eliminated systematically
later.

In this case, I don't mind introducing one more source of mismatch.

[Xiaocheng, 2017-04-27 03:04:26]

Let's land the fix in this patch. It also fixes http://crbug.com/712984

[Xiaocheng, 2017-04-27 16:59:55]

Could you close this CL, since crrev.com/2850443002 is landed?

Thanks!