EXPERIMENT Make toPositionInFlatTree() to return null for DOM position not in flat tree

third_party/WebKit/Source/core/editing/SelectionEditor.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 359 matching lines @@
   if (!needsUpdateVisibleSelection())
     return;
 
   m_styleVersion = document().styleVersion();
   m_cacheIsDirty = false;
   m_cachedVisibleSelectionInDOMTree = createVisibleSelection(m_selection);
   if (m_cachedVisibleSelectionInDOMTree.isNone()) {
     m_cachedVisibleSelectionInFlatTree = VisibleSelectionInFlatTree();
     return;
   }
-  m_cachedVisibleSelectionInFlatTree = createVisibleSelection(
-      SelectionInFlatTree::Builder()
-          .setBaseAndExtent(toPositionInFlatTree(m_selection.base()),
-                            toPositionInFlatTree(m_selection.extent()))
-          .setAffinity(m_selection.affinity())
-          .setHasTrailingWhitespace(m_selection.hasTrailingWhitespace())
-          .setGranularity(m_selection.granularity())
-          .setIsDirectional(m_selection.isDirectional())
-          .build());
+  const PositionInFlatTree& base = toPositionInFlatTree(m_selection.base());
+  const PositionInFlatTree& extent = toPositionInFlatTree(m_selection.extent());
+  SelectionInFlatTree::Builder builder;
+  builder.setAffinity(m_selection.affinity())
+      .setHasTrailingWhitespace(m_selection.hasTrailingWhitespace())
+      .setGranularity(m_selection.granularity())
+      .setIsDirectional(m_selection.isDirectional());
+  // TODO(editing-dev): Is it better to adjust base and extent if they are not
+  // in flat tree?
+  if (base.isNotNull() && extent.isNotNull())
+    builder.setBaseAndExtent(base, extent);
+  else if (base.isNotNull())
+    builder.collapse(base);
+  else if (extent.isNotNull())
+    builder.collapse(extent);
+  m_cachedVisibleSelectionInFlatTree = createVisibleSelection(builder.build());

[Xiaocheng, 2017/03/27 18:17:45]

Is it fine if the cached VS and VSInFlatTree have different types (e.g., VS is
range but VSInFlatTree is Caret)?

[yosin_UTC9, 2017/03/29 03:20:21]

So far, we did adjustment in [1] which removed adjustment function. However, it
doesn't handle this case.
We want to have smarter adjustment, e.g. move a position before shadow host,
etc.

Since we're rewriting selection paint adjustment for layout NG, this case should
be handle there.

[1] http://crrrev.com/2706003002: Get rid of unused functions
SelectionAdjuster::adjustSelectionIn{DOM,Flat}Tree

[Xiaocheng, 2017/03/29 23:56:40]

OK. So the type mismatch currently exists, and will be eliminated systematically
later.

In this case, I don't mind introducing one more source of mismatch.

 }
 
 void SelectionEditor::cacheRangeOfDocument(Range* range) {
   m_cachedRange = range;
 }
 
 Range* SelectionEditor::documentCachedRange() const {
   return m_cachedRange;
 }
 
 void SelectionEditor::clearDocumentCachedRange() {
   m_cachedRange = nullptr;
 }
 
 DEFINE_TRACE(SelectionEditor) {
   visitor->trace(m_frame);
   visitor->trace(m_selection);
   visitor->trace(m_cachedVisibleSelectionInDOMTree);
   visitor->trace(m_cachedVisibleSelectionInFlatTree);
   visitor->trace(m_cachedRange);
   SynchronousMutationObserver::trace(visitor);
 }
 
 }  // namespace blink