Move EditingUtilities::isNodeVisiblyContainedWithin() to CompositeEditCommand

Move EditingUtilities::isNodeVisiblyContainedWithin() to CompositeEditCommand

That's because it is used only from CompositeEditCommand subclasses.

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2772203002
Cr-Commit-Position: refs/heads/master@{#459732}
Committed: https://chromium.googlesource.com/chromium/src/+/8e45386fb683e55cd2354e5537c352b3cf8303c6

[yoichio, 2017-03-27 07:22:18]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-27 07:23:38]

Description was changed from

==========
Move EditingUtilities

TEST=No change in behavior
==========

to

==========
Move EditingUtilities::isNodeVisiblyContainedWithin() to CompositeEditCommand

That's because it is used only from CompositeEditCommand subclasses.

TEST=No change in behavior
==========

[yoichio, 2017-03-27 07:46:09]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:42:39]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-27 08:54:39]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-27 08:54:39]

lgtm

[commit-bot: I haz the power, 2017-03-27 08:54:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-27 08:55:40]

https://codereview.chromium.org/2772203002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2772203002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:224:
static bool isNodeVisiblyContainedWithin(Node&, const Range&);
We don't need this function as static class member.
It should be file local static function.

[yosin_UTC9, 2017-03-27 08:55:52]

The CQ bit was unchecked by yosin@chromium.org

[yoichio, 2017-03-27 09:13:11]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-03-27 09:13:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-27 09:14:50]

On 2017/03/27 08:55:40, yosin_UTC9 wrote:
>
https://codereview.chromium.org/2772203002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
> (right):
> 
>
https://codereview.chromium.org/2772203002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:224:
> static bool isNodeVisiblyContainedWithin(Node&, const Range&);
> We don't need this function as static class member.
> It should be file local static function.
This function is used by ApplyStyleCommand, InsertListCommand and
FormatBlockCommand as described.

[commit-bot: I haz the power, 2017-03-27 09:35:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490605991221790, "parent_rev":
"c31ec95e72b921cc625e8a48e7064721fc85de09", "commit_rev":
"8e45386fb683e55cd2354e5537c352b3cf8303c6"}

[commit-bot: I haz the power, 2017-03-27 09:36:18]

Description was changed from

==========
Move EditingUtilities::isNodeVisiblyContainedWithin() to CompositeEditCommand

That's because it is used only from CompositeEditCommand subclasses.

TEST=No change in behavior
==========

to

==========
Move EditingUtilities::isNodeVisiblyContainedWithin() to CompositeEditCommand

That's because it is used only from CompositeEditCommand subclasses.

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2772203002
Cr-Commit-Position: refs/heads/master@{#459732}
Committed:
https://chromium.googlesource.com/chromium/src/+/8e45386fb683e55cd2354e5537c3...
==========

[commit-bot: I haz the power, 2017-03-27 09:36:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e45386fb683e55cd2354e5537c3...