Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2772193006: gpu: Replace GpuMsg_GpuSwitched with mojom api. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
Tom Sepez, piman
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Replace GpuMsg_GpuSwitched with mojom api. Introduce mojom.GpuService.GpuSwitched(), to replace GpuMsg_GpuSwitched. This removes the last IPC message handled by GpuChildThread, and this also removes the last use of GpuProcessHost::SendOnIO(). So remove these dead code at the same time. BUG=643746 Review-Url: https://codereview.chromium.org/2772193006 Cr-Commit-Position: refs/heads/master@{#460272} Committed: https://chromium.googlesource.com/chromium/src/+/d93a2b102eb48ba6dbaa0ac11dff9edc4d1eec9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -65 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M services/ui/gpu/gpu_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/gpu_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service.mojom View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
sadrul
tsepez@ for ipc changes. piman@ for all changes. Thank you!
3 years, 8 months ago (2017-03-28 20:16:48 UTC) #4
Tom Sepez
LGTM for moving equivalent functionality.
3 years, 8 months ago (2017-03-28 20:40:00 UTC) #7
piman
LGTM, thanks for the cleanup
3 years, 8 months ago (2017-03-28 22:01:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772193006/1
3 years, 8 months ago (2017-03-29 01:04:12 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:13:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d93a2b102eb48ba6dbaa0ac11dff...

Powered by Google App Engine
This is Rietveld 408576698