Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2772013002: Fetch API: Fix behavior when Request constructor is passed an undefined referrer (Closed)

Created:
3 years, 9 months ago by yiyix
Modified:
3 years, 9 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik, varkha
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch API: Fix behavior when Request constructor is passed an undefined referrer When the Request constructor was called with referrer set to undefined, the resulting referrer used "undefined" as a string. After this code change, an undefined referrer will be considered as not present and the default referrer "about:client" will instead be used. BUG=624278 Review-Url: https://codereview.chromium.org/2772013002 Cr-Commit-Position: refs/heads/master@{#460049} Committed: https://chromium.googlesource.com/chromium/src/+/617eed180347e987f47df9bf74ae4eb20ac04cb1

Patch Set 1 #

Patch Set 2 : add tests #

Total comments: 2

Patch Set 3 : nits #

Total comments: 2

Patch Set 4 : address comments #

Patch Set 5 : update expectation + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-base-https-other-https-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/serviceworker/request-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/window/request-base-https-other-https-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/window/request-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-base-https-other-https-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/workers/request-expected.txt View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Dictionary.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/RequestInit.cpp View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 48 (27 generated)
yiyix
3 years, 9 months ago (2017-03-24 07:11:39 UTC) #5
yiyix
@falken, could you please take a look at this change?
3 years, 9 months ago (2017-03-24 07:17:35 UTC) #6
falken
This treats {referrer: undefined} the same as {referrer: null} which I don't think is right. ...
3 years, 9 months ago (2017-03-27 01:41:59 UTC) #8
falken
On 2017/03/27 01:41:59, falken wrote: > This treats {referrer: undefined} the same as {referrer: null} ...
3 years, 9 months ago (2017-03-27 01:53:43 UTC) #9
yiyix
On 2017/03/27 01:53:43, falken wrote: > On 2017/03/27 01:41:59, falken wrote: > > This treats ...
3 years, 9 months ago (2017-03-27 06:55:32 UTC) #10
domenic
On 2017/03/27 at 06:55:32, yiyix wrote: > I agree that we should add test cases ...
3 years, 9 months ago (2017-03-27 07:16:53 UTC) #15
falken
On 2017/03/27 07:16:53, domenic wrote: > On 2017/03/27 at 06:55:32, yiyix wrote: > > > ...
3 years, 9 months ago (2017-03-27 07:22:27 UTC) #16
yiyix
On 2017/03/27 07:22:27, falken wrote: > On 2017/03/27 07:16:53, domenic wrote: > > On 2017/03/27 ...
3 years, 9 months ago (2017-03-27 09:01:28 UTC) #22
falken
lgtm nits for the CL description: this change is about the Request constructor, not "fetch ...
3 years, 9 months ago (2017-03-27 09:09:19 UTC) #23
falken
Adding OWNERs too: +bashi for bindings +yhirano for fetch
3 years, 9 months ago (2017-03-27 09:11:02 UTC) #25
yiyix
https://codereview.chromium.org/2772013002/diff/80001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js (right): https://codereview.chromium.org/2772013002/diff/80001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js#newcode413 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js:413: "/null"; On 2017/03/27 09:09:19, falken wrote: > nit: use ...
3 years, 9 months ago (2017-03-27 09:19:48 UTC) #27
haraken
LGTM
3 years, 9 months ago (2017-03-27 09:23:26 UTC) #28
yhirano
lgtm https://codereview.chromium.org/2772013002/diff/100001/third_party/WebKit/Source/modules/fetch/RequestInit.cpp File third_party/WebKit/Source/modules/fetch/RequestInit.cpp (right): https://codereview.chromium.org/2772013002/diff/100001/third_party/WebKit/Source/modules/fetch/RequestInit.cpp#newcode31 third_party/WebKit/Source/modules/fetch/RequestInit.cpp:31: : areAnyMembersSet(false) { Can you put a TODO ...
3 years, 9 months ago (2017-03-27 10:38:52 UTC) #29
bashi
lgtm. (We should improve our code generator so that we can write RequestInit.idl and remove ...
3 years, 9 months ago (2017-03-27 23:14:29 UTC) #30
yiyix
https://codereview.chromium.org/2772013002/diff/100001/third_party/WebKit/Source/modules/fetch/RequestInit.cpp File third_party/WebKit/Source/modules/fetch/RequestInit.cpp (right): https://codereview.chromium.org/2772013002/diff/100001/third_party/WebKit/Source/modules/fetch/RequestInit.cpp#newcode31 third_party/WebKit/Source/modules/fetch/RequestInit.cpp:31: : areAnyMembersSet(false) { On 2017/03/27 10:38:51, yhirano wrote: > ...
3 years, 9 months ago (2017-03-28 02:34:06 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772013002/120001
3 years, 9 months ago (2017-03-28 02:34:30 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/417722)
3 years, 9 months ago (2017-03-28 04:03:17 UTC) #36
falken
On 2017/03/28 04:03:17, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-28 05:56:01 UTC) #37
yiyix
On 2017/03/28 05:56:01, falken wrote: > On 2017/03/28 04:03:17, commit-bot: I haz the power wrote: ...
3 years, 9 months ago (2017-03-28 06:37:32 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772013002/140001
3 years, 9 months ago (2017-03-28 09:00:14 UTC) #45
commit-bot: I haz the power
3 years, 9 months ago (2017-03-28 09:25:06 UTC) #48
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/617eed180347e987f47df9bf74ae...

Powered by Google App Engine
This is Rietveld 408576698