Added headless permission manager. This permissions manager simply acks all permission requests wit…

Added headless permission manager. This permissions manager simply acks all permission requests without accepting or denying.

BUG=704820
Review-Url: https://codereview.chromium.org/2771993003
Cr-Commit-Position: refs/heads/master@{#460036}
Committed: https://chromium.googlesource.com/chromium/src/+/8bdb9db76cebc9398316e15e2669837f99bea61c

[Oleg Sushkov, 2017-03-24 05:25:52]

Description was changed from

==========
Added headless permission manager. This permissions manager simply acks all
permission requests without accepting or denying.

BUG=
==========

to

==========
Added headless permission manager. This permissions manager simply acks all
permission requests without accepting or denying.

BUG=704820
==========

[Oleg Sushkov, 2017-03-24 05:26:50]

sushkov@chromium.org changed reviewers:
+ alexclarke@chromium.org

[Oleg Sushkov, 2017-03-24 05:28:09]

Hi Alex, I've added a HeadlessPermissionsManager that acks all permission
requests without accepting or denying them. This is in contrast to the previous
behaviour where all permissions were implicitly interpreted as denied. The
specific issue this fixes is it allows Lighthouse to detect whether a website
asks for permissions in onload.

[alex clarke (OOO till 29th), 2017-03-24 16:26:37]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2017-03-24 16:26:37]

I think this is probably fine but I don't know anything about the
PermissionMananager.  Sami WDYT?

[Sami, 2017-03-24 16:49:47]

This seems like reasonable default behavior. Would you mind adding a small smoke
test that loads a page which requests a permission just to exercise this code?

https://codereview.chromium.org/2771993003/diff/1/headless/lib/browser/headle...
File headless/lib/browser/headless_permission_manager.cc (right):

https://codereview.chromium.org/2771993003/diff/1/headless/lib/browser/headle...
headless/lib/browser/headless_permission_manager.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
2017

[Sami, 2017-03-24 16:59:30]

I checked with beverloo@ that returning ASK is a good default here.

[Oleg Sushkov, 2017-03-27 05:42:17]

On 2017/03/24 at 16:49:47, skyostil wrote:
> This seems like reasonable default behavior. Would you mind adding a small
smoke test that loads a page which requests a permission just to exercise this
code?
> 
>
https://codereview.chromium.org/2771993003/diff/1/headless/lib/browser/headle...
> File headless/lib/browser/headless_permission_manager.cc (right):
> 
>
https://codereview.chromium.org/2771993003/diff/1/headless/lib/browser/headle...
> headless/lib/browser/headless_permission_manager.cc:1: // Copyright 2015 The
Chromium Authors. All rights reserved.
> 2017

Done, and added a test.

[Sami, 2017-03-27 15:54:00]

lgtm, thank you.

[Oleg Sushkov, 2017-03-27 22:59:37]

The CQ bit was checked by sushkov@chromium.org

[commit-bot: I haz the power, 2017-03-27 23:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 00:29:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 00:29:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Oleg Sushkov, 2017-03-28 04:20:33]

The CQ bit was checked by sushkov@chromium.org

[commit-bot: I haz the power, 2017-03-28 04:20:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Oleg Sushkov, 2017-03-28 05:05:49]

The CQ bit was checked by sushkov@chromium.org

[Oleg Sushkov, 2017-03-28 05:05:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2771993003/#ps40001
(title: "Added headless permission manager. This permissions manager simply acks
all permission requests wit…")

[commit-bot: I haz the power, 2017-03-28 05:06:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 07:29:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490677549370690,
"parent_rev": "d8cd72b77ad75432b531dd5d2c5d866544a2240c", "commit_rev":
"8bdb9db76cebc9398316e15e2669837f99bea61c"}

[commit-bot: I haz the power, 2017-03-28 07:30:37]

Description was changed from

==========
Added headless permission manager. This permissions manager simply acks all
permission requests without accepting or denying.

BUG=704820
==========

to

==========
Added headless permission manager. This permissions manager simply acks all
permission requests without accepting or denying.

BUG=704820

Review-Url: https://codereview.chromium.org/2771993003
Cr-Commit-Position: refs/heads/master@{#460036}
Committed:
https://chromium.googlesource.com/chromium/src/+/8bdb9db76cebc9398316e15e2669...
==========

[commit-bot: I haz the power, 2017-03-28 07:30:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8bdb9db76cebc9398316e15e2669...