Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2771983006: Log AVERROR messages from FFmpegDemuxer in chrome://media-internals. (Closed)

Created:
3 years, 9 months ago by sandersd (OOO until July 31)
Modified:
3 years, 8 months ago
Reviewers:
*DaleCurtis, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log AVERROR messages from FFmpegDemuxer in chrome://media-internals. This uses the same mechanism as was added to allow FFmpegVideoDecoder to convert AVERROR codes into messages, and logs the resulting message at the DEBUG media-log level. BUG=705152 Review-Url: https://codereview.chromium.org/2771983006 Cr-Commit-Position: refs/heads/master@{#459877} Committed: https://chromium.googlesource.com/chromium/src/+/b20148e73c9d380f84968dac00dae26425d05b78

Patch Set 1 #

Patch Set 2 : Update FFmpegVideoDecoder log message format to match. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M media/filters/ffmpeg_demuxer.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 5 chunks +18 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
sandersd (OOO until July 31)
3 years, 9 months ago (2017-03-24 23:29:50 UTC) #3
DaleCurtis
lgtm, BUG= + description?
3 years, 9 months ago (2017-03-24 23:31:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771983006/20001
3 years, 9 months ago (2017-03-25 00:33:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391290)
3 years, 9 months ago (2017-03-25 01:49:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771983006/20001
3 years, 9 months ago (2017-03-27 18:04:04 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-03-27 21:01:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b20148e73c9d380f84968dac00da...

Powered by Google App Engine
This is Rietveld 408576698