Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2771983002: Remove Page::m_frameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Page::m_frameHost Remove Page::m_frameHost and FrameHost() method. BUG=688614 Review-Url: https://codereview.chromium.org/2771983002 Cr-Commit-Position: refs/heads/master@{#460275} Committed: https://chromium.googlesource.com/chromium/src/+/015f5eb0b4fb4d6b3de8cb8aeda89fb1eacc2e24

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M third_party/WebKit/Source/core/page/Page.h View 1 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
sashab
3 years, 9 months ago (2017-03-24 00:46:31 UTC) #2
joelhockey
lgtm
3 years, 9 months ago (2017-03-24 01:46:14 UTC) #3
sashab
ty joel. haraken ptal
3 years, 9 months ago (2017-03-24 01:56:55 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-24 02:01:57 UTC) #6
dglazkov
lgtm
3 years, 9 months ago (2017-03-27 20:15:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771983002/1
3 years, 8 months ago (2017-03-28 22:41:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/393540)
3 years, 8 months ago (2017-03-28 22:57:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771983002/20001
3 years, 8 months ago (2017-03-28 23:01:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/259741) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 00:36:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771983002/20001
3 years, 8 months ago (2017-03-29 03:03:11 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:23:39 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/015f5eb0b4fb4d6b3de8cb8aeda8...

Powered by Google App Engine
This is Rietveld 408576698