Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2771963002:
List all a11y featuers in ash system menu (Closed)
|
Created:
3 years, 9 months ago by minch1 Modified:
3 years, 8 months ago CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, aboxhall+watch_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, tracing+reviews_chromium.org, kalyank Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionList all a11y featuers in ash system menu
Old behavior,
'Automatic clicks' is disabled on login screen.
'Large mouse cursor' is disabled after login.
New behavior,
Keep the Accessibility detailed view in system tray the same in LOGIN | NOT LOGIN | LOCKED.
top five settings,
ChromeVox
High contrast mode
Screen magnifier
Automatic clicks
On-screen keyboard
and five Additional settings,
Large mouse cursor
Mono audio
Highlight text caret
Highlight mouse cursor
Highlight object with keyboard focus (this one will be invisible if ChromeVox is enabled)
BUG=632107
Review-Url: https://codereview.chromium.org/2771963002
Review-Url: https://codereview.chromium.org/2771963002
Cr-Commit-Position: refs/heads/master@{#461248}
Committed: https://chromium.googlesource.com/chromium/src/+/a0b24ab6769b406319d70bffd462266032a49ebb
Patch Set 1 #Patch Set 2 : List all a11y featuers in ash system menu #Patch Set 3 : Update the text of additional settings of a11y #
Total comments: 23
Patch Set 4 : Address the comments on PS#3 #
Total comments: 14
Patch Set 5 : Address comments on PS#4 #Patch Set 6 : Fix typo. #Patch Set 7 : Fix typo. #Messages
Total messages: 61 (44 generated)
Description was changed from ========== draft, to Sarah Fix typo in malloc dump provider function name R=primiano@chromium.org, erikchen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2765893002 Cr-Commit-Position: refs/heads/master@{#458448} ========== to ========== draft, to Sarah Fix typo in malloc dump provider function name R=primiano@chromium.org, erikchen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2765893002 Cr-Commit-Position: refs/heads/master@{#458448} ==========
minch@chromium.org changed reviewers: - erikchen@chromium.org, primiano@chromium.org
I am sorry for the codereview request. This CL is just a draft for Sarah to take a look.
Message was sent while issue was closed.
Description was changed from ========== draft, to Sarah Fix typo in malloc dump provider function name R=primiano@chromium.org, erikchen@chromium.org BUG= Review-Url: https://codereview.chromium.org/2765893002 Cr-Commit-Position: refs/heads/master@{#458448} ========== to ========== List all a11y featuers in ash system menu BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ==========
minch@chromium.org changed reviewers: + xiaoyinh@chromium.org
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
minch@chromium.org changed reviewers: + tdanderson@chromium.org, xiyuan@chromium.org
Can you help review?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please insert a blank line between subject and body. And document the behavior change in addition to the UI change once confirmed it is intended. i.e. List all a11y featuers in ash system menu <blank_line> BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (left): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:177: if (login_ == LoginStatus::NOT_LOGGED_IN) { Just double check that removing login status check is intended. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (right): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:176: highlight_keyboard_focus_enabled_(false), nit: Since you are here, could you move all member initializations into header. See "Non-Static Class Member Initializers" row in https://chromium-cpp.appspot.com/ https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:247: if (!spoken_feedback_enabled_) { nit: brief comment to document that "Focus highlighting can't be on when spoken feedback is on because ChromeVox does its own focus highlighting." https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.h (right): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); Can we pass HoverHighlightView* instead of **? https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); nit: I'd call this UpdateCheckMark. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); This function seems not touching any state in AccessibilityDetailedView. Can we move it into cc file in the anonymous namespace. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:88: void AddSubHeader(int message_id); nit: Can we pass in the string instead? i.e. void AddSubHeader(const base::string16& header); https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (left): https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:830: SetLoginStatus(ash::LoginStatus::USER); Please confirm with PM or a11y owner about the behavior change. And if it is intended, mention it in CL description. https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1368: // Except help & settings, others shold keep the same in LOGIN / NOT LOGIN / nit: shold -> should keep -> be kept
https://codereview.chromium.org/2771963002/diff/40001/ash/metrics/user_metric... File ash/metrics/user_metrics_recorder.cc (right): https://codereview.chromium.org/2771963002/diff/40001/ash/metrics/user_metric... ash/metrics/user_metrics_recorder.cc:400: RecordAction(UserMetricsAction("StatusArea_MonoAudioDisabled")); These metrics actions seems to be missing from tools/metrics/actions/actions.xml. Could you update actions.xml as well?
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Description was changed from ========== List all a11y featuers in ash system menu BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ========== to ========== List all a11y featuers in ash system menu BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Hi, xiyuan@, xiaoyinh@, can you help review PS#4, which addressed the comments on PS#3. tdanderson@, can you help confirm the change to make 'automatic clicks' visible in the ash system menu regardless of LOGIN or NOT LOGIN. And the same as 'Large mouse cursor'? https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (left): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:177: if (login_ == LoginStatus::NOT_LOGGED_IN) { On 2017/03/28 20:11:25, xiyuan wrote: > Just double check that removing login status check is intended. hi, tdanderson@, can you help confirm this? https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (right): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:176: highlight_keyboard_focus_enabled_(false), On 2017/03/28 20:11:25, xiyuan wrote: > nit: Since you are here, could you move all member initializations into header. > > See "Non-Static Class Member Initializers" row in > https://chromium-cpp.appspot.com/ Done. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:247: if (!spoken_feedback_enabled_) { On 2017/03/28 20:11:25, xiyuan wrote: > nit: brief comment to document that "Focus highlighting can't be on when spoken > feedback is on because ChromeVox does its own focus highlighting." Done. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.h (right): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); On 2017/03/28 20:11:25, xiyuan wrote: > This function seems not touching any state in AccessibilityDetailedView. Can we > move it into cc file in the anonymous namespace. Done. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); On 2017/03/28 20:11:25, xiyuan wrote: > Can we pass HoverHighlightView* instead of **? Done. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:86: void CheckOrUncheckMark(HoverHighlightView** container, bool checked); On 2017/03/28 20:11:25, xiyuan wrote: > nit: I'd call this UpdateCheckMark. Done. https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:88: void AddSubHeader(int message_id); On 2017/03/28 20:11:25, xiyuan wrote: > nit: Can we pass in the string instead? > i.e. > void AddSubHeader(const base::string16& header); Hi,xiyuan. I guess here is to make the function readable? I changed the function as following, void AddSubHeader(const base::string16& header_text) https://codereview.chromium.org/2771963002/diff/40001/ash/metrics/user_metric... File ash/metrics/user_metrics_recorder.cc (right): https://codereview.chromium.org/2771963002/diff/40001/ash/metrics/user_metric... ash/metrics/user_metrics_recorder.cc:400: RecordAction(UserMetricsAction("StatusArea_MonoAudioDisabled")); On 2017/03/28 21:28:12, xiaoyinh wrote: > These metrics actions seems to be missing from > tools/metrics/actions/actions.xml. Could you update actions.xml as well? Done. https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (left): https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:830: SetLoginStatus(ash::LoginStatus::USER); On 2017/03/28 20:11:26, xiyuan wrote: > Please confirm with PM or a11y owner about the behavior change. And if it is > intended, mention it in CL description. Hi, tdanderson@, can you help confirm this? https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1368: // Except help & settings, others shold keep the same in LOGIN / NOT LOGIN / On 2017/03/28 20:11:26, xiyuan wrote: > nit: shold -> should > keep -> be kept Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.h (right): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.h:88: void AddSubHeader(int message_id); On 2017/03/29 01:15:11, minch1 wrote: > On 2017/03/28 20:11:25, xiyuan wrote: > > nit: Can we pass in the string instead? > > i.e. > > void AddSubHeader(const base::string16& header); > > Hi,xiyuan. I guess here is to make the function readable? I changed the function > as following, > void AddSubHeader(const base::string16& header_text) SG. https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (right): https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:102: } nit: insert a blank line after this line https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:1369: // / LOCKED. https://crbug.com/632107. nit: starting with "/" looks confusing. Can you reformat a bit to avoid that?
The CL is looking good so far, I have left a few comments below: https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (left): https://codereview.chromium.org/2771963002/diff/40001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:177: if (login_ == LoginStatus::NOT_LOGGED_IN) { On 2017/03/29 01:15:11, minch1 wrote: > On 2017/03/28 20:11:25, xiyuan wrote: > > Just double check that removing login status check is intended. > > hi, tdanderson@, can you help confirm this? Yes, I spoke with the a11y PM (lpalmaro@) a while back and she said there is no reason to keep this restriction. And as far as I know there should be no technical reason to keep it, either. https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (left): https://codereview.chromium.org/2771963002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:830: SetLoginStatus(ash::LoginStatus::USER); On 2017/03/29 01:15:11, minch1 wrote: > On 2017/03/28 20:11:26, xiyuan wrote: > > Please confirm with PM or a11y owner about the behavior change. And if it is > > intended, mention it in CL description. > > Hi, tdanderson@, can you help confirm this? Yes this was also ok'ed by lpalmaro@. However to be on the safe side can you please run this by zork@ to see if he would know of any reason (security-related or otherwise) that we may want to have auto-click disabled on the login screen? https://codereview.chromium.org/2771963002/diff/60001/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/2771963002/diff/60001/ash/ash_strings.grd#new... ash/ash_strings.grd:330: <message name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_ADDITIONAL_SETTINGS" desc="The sub-header label for additional setting in accessibility menu of system tray."> nit: please add these strings in alphabetical order based on the IDS_ name https://codereview.chromium.org/2771963002/diff/60001/ash/common/metrics/user... File ash/common/metrics/user_metrics_action.h (right): https://codereview.chromium.org/2771963002/diff/60001/ash/common/metrics/user... ash/common/metrics/user_metrics_action.h:94: UMA_STATUS_AREA_ENABLE_MONO_AUDIO, Same comment as in ash_strings.grd, please add these in alphabetical order. https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... File ash/common/system/tray_accessibility.cc (right): https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:90: void UpdateCheckMark(HoverHighlightView* container, bool checked) { Thanks for moving this into a helper function. It looks like this code is also duplicated in some other detailed views, (see audio_detailed_view.cc as an example) and it is always good to share code wherever possible. Don't worry about changing it in this CL, but I will make a note of this and other refactoring opportunities in a follow-on bug. https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:240: // feedback is on because ChromeVox does its own focus highlighting. Thanks for adding this comment, it's very helpful. nit: Please have the first line wrap as close to 80 characters as possible. https://codereview.chromium.org/2771963002/diff/60001/ash/common/system/tray_... ash/common/system/tray_accessibility.cc:291: scroll_content()->AddChildView(new views::Separator()); Just instantiating a Separator() will not end up giving you the correct separator color and padding values above/below. Have a look at TrayPopupUtils::CreateListSubHeaderSeparator() used by some of the other detailed views in the system menu; that utility function sets up the color and padding for the separator in a way that will be consistent across all detailed views. nit: also, since the separator is not part of the sub-header, could you move this line out of AddSubHeader() and place it above line 223? https://codereview.chromium.org/2771963002/diff/60001/ash/metrics/user_metric... File ash/metrics/user_metrics_recorder.cc (right): https://codereview.chromium.org/2771963002/diff/60001/ash/metrics/user_metric... ash/metrics/user_metrics_recorder.cc:399: case UMA_STATUS_AREA_DISABLE_MONO_AUDIO: ditto to the previous files, please arrange these in alphabetical order https://codereview.chromium.org/2771963002/diff/60001/tools/metrics/actions/a... File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2771963002/diff/60001/tools/metrics/actions/a... tools/metrics/actions/actions.xml:15435: Ash system menu: Accessibility: Disable play the same audio through all nit: I think it would be better to just have the description here be "Ash system menu: Accessibility: Disable mono audio" (similar for line 15443).
https://codereview.chromium.org/2771963002/diff/60001/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/2771963002/diff/60001/ash/ash_strings.grd#new... ash/ash_strings.grd:330: <message name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_ADDITIONAL_SETTINGS" desc="The sub-header label for additional setting in accessibility menu of system tray."> On 2017/03/29 18:57:03, tdanderson wrote: > nit: please add these strings in alphabetical order based on the IDS_ name My mistake, I assumed these were already in alphabetical order, but they are not. This is fine as-is. https://codereview.chromium.org/2771963002/diff/60001/ash/common/metrics/user... File ash/common/metrics/user_metrics_action.h (right): https://codereview.chromium.org/2771963002/diff/60001/ash/common/metrics/user... ash/common/metrics/user_metrics_action.h:94: UMA_STATUS_AREA_ENABLE_MONO_AUDIO, On 2017/03/29 18:57:03, tdanderson wrote: > Same comment as in ash_strings.grd, please add these in alphabetical order. These look like they're (mostly) already in alphabetical order, though, so please add the new lines accordingly (ditto for the UMA_ lines in user_metrics_recorder.cc)
lgtm. https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/system/tray_accessibility_browsertest.cc (right): https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:529: // Toggling caert highlight changes the visibility of the menu. nit: Toggling "caret" highlight... https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:635: // The menu remains visibile regardless of toggling large mousr cursor. nit: toggling large "mouse" cursor. https://codereview.chromium.org/2771963002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/system/tray_accessibility_browsertest.cc:747: // The menu remains visibile regardless of toggling large mousr cursor. nits: large "mouse" cursor.
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== List all a11y featuers in ash system menu BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ========== to ========== List all a11y featuers in ash system menu Old behavior, 'Automatic clicks' is disabled on login screen. 'Large mouse cursor' is disabled after login. New behavior, Keep the Accessibility detailed view in system tray the same in LOGIN | NOT LOGIN | LOCKED. top five settings, ChromeVox High contrast mode Screen magnifier Automatic clicks On-screen keyboard and five Additional settings, Large mouse cursor Mono audio Highlight text caret Highlight mouse cursor Highlight object with keyboard focus (this one will be invisible if ChromeVox is enabled) BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ==========
Hi, tdanderson@, can you help take a look of the new PS. And I confirmed with zork@. He believes it is ok to enable 'automatic clicks' in login screen.
On 2017/03/29 21:35:28, minch1 wrote: > Hi, tdanderson@, can you help take a look of the new PS. And I confirmed with > zork@. He believes it is ok to enable 'automatic clicks' in login screen. Sounds good to me, thanks for checking. ash/ in patch set 6 LGTM.
minch@chromium.org changed reviewers: + holte@chromium.org, stevenjb@chromium.org
Hi, stevenjb@, holte@, can you help review my CL. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by minch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by minch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xiaoyinh@chromium.org, xiyuan@chromium.org, tdanderson@chromium.org, stevenjb@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2771963002/#ps120001 (title: "Fix typo.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1490998109815160,
"parent_rev": "28ab845b881eb65ca9b76d3a6695d9d3599474b2", "commit_rev":
"a0b24ab6769b406319d70bffd462266032a49ebb"}
Message was sent while issue was closed.
Description was changed from ========== List all a11y featuers in ash system menu Old behavior, 'Automatic clicks' is disabled on login screen. 'Large mouse cursor' is disabled after login. New behavior, Keep the Accessibility detailed view in system tray the same in LOGIN | NOT LOGIN | LOCKED. top five settings, ChromeVox High contrast mode Screen magnifier Automatic clicks On-screen keyboard and five Additional settings, Large mouse cursor Mono audio Highlight text caret Highlight mouse cursor Highlight object with keyboard focus (this one will be invisible if ChromeVox is enabled) BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 ========== to ========== List all a11y featuers in ash system menu Old behavior, 'Automatic clicks' is disabled on login screen. 'Large mouse cursor' is disabled after login. New behavior, Keep the Accessibility detailed view in system tray the same in LOGIN | NOT LOGIN | LOCKED. top five settings, ChromeVox High contrast mode Screen magnifier Automatic clicks On-screen keyboard and five Additional settings, Large mouse cursor Mono audio Highlight text caret Highlight mouse cursor Highlight object with keyboard focus (this one will be invisible if ChromeVox is enabled) BUG=632107 Review-Url: https://codereview.chromium.org/2771963002 Review-Url: https://codereview.chromium.org/2771963002 Cr-Commit-Position: refs/heads/master@{#461248} Committed: https://chromium.googlesource.com/chromium/src/+/a0b24ab6769b406319d70bffd462... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/a0b24ab6769b406319d70bffd462... |
