Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2771933002: Update createImageData/getImageData/putImageData from float to long (Closed)

Created:
3 years, 9 months ago by fserb
Modified:
3 years, 8 months ago
Reviewers:
Justin Novosad
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, Rik, chromium-reviews, dshwang, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update createImageData/getImageData/putImageData from float to long On both CanvasRenderingContext2D and OffscreenCanvas. BUG=701490 Review-Url: https://codereview.chromium.org/2771933002 Cr-Commit-Position: refs/heads/master@{#461455} Committed: https://chromium.googlesource.com/chromium/src/+/5aae822c218a67b706125e9620290026d523d629

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Reset tests #

Messages

Total messages: 22 (15 generated)
fserb
I know my test changes look extremely suspicious, but if you have an open heart ...
3 years, 9 months ago (2017-03-23 20:57:30 UTC) #4
Justin Novosad
lgtm, but you have to rebase the failing tests. The tests under philip/ are from ...
3 years, 9 months ago (2017-03-24 17:05:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771933002/20001
3 years, 8 months ago (2017-03-31 21:08:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/419735)
3 years, 8 months ago (2017-03-31 22:45:47 UTC) #15
fserb
3 years, 8 months ago (2017-04-03 14:59:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771933002/40001
3 years, 8 months ago (2017-04-03 14:59:40 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 16:51:20 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5aae822c218a67b706125e962029...

Powered by Google App Engine
This is Rietveld 408576698