Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2771923006: Add CVPixelBufferRef memory tracking (Closed)

Created:
3 years, 9 months ago by ccameron
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mac-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CVPixelBufferRef memory tracking Create a separate sequence number for GLImages created from CVPixelBufferRefs (previously they had no sequence number, so they would alias each other). Make VTVideoDecodeAccelerator be a dump provider. This dumps through the GLImage interface, and so it will correctly link the CVPixelBufferRefs that with the command buffer textures. Fix TextureManager's dump code to not assume that GLImage presence and texture state BOUND are related (a texture can have a GLImage but not be BOUND because it can't be textured out of directly). BUG=704792 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2771923006 Cr-Commit-Position: refs/heads/master@{#460566} Committed: https://chromium.googlesource.com/chromium/src/+/4bb4e7702c8432bd1ec6843a9b7dee6f3e6e2eb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -8 lines) Patch
M gpu/command_buffer/service/texture_manager.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.h View 4 chunks +10 lines, -1 line 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 4 chunks +34 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
ccameron
ptal: ericrk: make sure this makes sense jbauman: gpu/command_buffer/ OWNER sandersd: media/ OWNER
3 years, 9 months ago (2017-03-25 00:09:16 UTC) #3
sandersd (OOO until July 31)
media/ lgtm.
3 years, 9 months ago (2017-03-25 00:41:07 UTC) #4
jbauman
lgtm
3 years, 9 months ago (2017-03-27 21:55:42 UTC) #5
ericrk
Lgtm - thanks for taking care of this!
3 years, 8 months ago (2017-03-28 15:46:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923006/1
3 years, 8 months ago (2017-03-28 19:23:28 UTC) #8
commit-bot: I haz the power
CQ has no permission to schedule in bucket master.tryserver.chromium.linux
3 years, 8 months ago (2017-03-28 21:15:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923006/1
3 years, 8 months ago (2017-03-28 23:51:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 00:16:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771923006/1
3 years, 8 months ago (2017-03-29 20:56:24 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 23:04:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bb4e7702c8432bd1ec6843a9b7d...

Powered by Google App Engine
This is Rietveld 408576698