content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_database.proto ('K') | « content/browser/service_worker/service_worker_write_to_cache_job.h ('k') | content/child/service_worker/service_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

index 317ade5ef146e4a23b1f020d7c9bdf9b9c4a309a..93985f28d0e3e6c6c61a6bb7ddce3733ed55a73e 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

@@ -335,8 +335,8 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

helper_.reset(new EmbeddedWorkerTestHelper(base::FilePath()));

// A new unstored registration/version.

- registration_ =

- new ServiceWorkerRegistration(scope_, 1L, context()->AsWeakPtr());

+ registration_ = new ServiceWorkerRegistration(

+ ServiceWorkerRegistrationOptions(scope_), 1L, context()->AsWeakPtr());

version_ =

new ServiceWorkerVersion(registration_.get(), script_url_,

NextVersionId(), context()->AsWeakPtr());