content/browser/service_worker/service_worker_write_to_cache_job.h - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.h

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_write_to_cache_job.h

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.h b/content/browser/service_worker/service_worker_write_to_cache_job.h

index 290a129251f047bf30305bed5c57770a6a510da3..99e51bae0a5278f6b99126e9757354b0eefe4612 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job.h

+++ b/content/browser/service_worker/service_worker_write_to_cache_job.h

@@ -63,7 +63,9 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

UpdateBefore24Hours);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

- UpdateAfter24Hours);

+ UpdateBefore24HoursUsingCache);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

+ UpdateAfter24HoursUsingCache);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

UpdateForceBypassCache);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,