chrome/browser/chrome_service_worker_browsertest.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_service_worker_browsertest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc ('k') | content/browser/background_fetch/background_fetch_test_base.cc » ('j') | content/browser/service_worker/link_header_support.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_service_worker_browsertest.cc

diff --git a/chrome/browser/chrome_service_worker_browsertest.cc b/chrome/browser/chrome_service_worker_browsertest.cc

index ae3b7e529e690bca89383e54da714fccd53199ee..c2d71fcdab0dabf25606aaabe22786580459964b 100644

--- a/chrome/browser/chrome_service_worker_browsertest.cc

+++ b/chrome/browser/chrome_service_worker_browsertest.cc

@@ -34,6 +34,7 @@

#include "content/public/test/browser_test_utils.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

#include "ppapi/shared_impl/ppapi_switches.h"

+#include "third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerUpdateViaCache.h"

namespace {

@@ -117,6 +118,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,

GetServiceWorkerContext()->RegisterServiceWorker(

embedded_test_server()->GetURL("/"),

embedded_test_server()->GetURL("/service_worker.js"),

+ blink::WebServiceWorkerUpdateViaCache::kImports,

base::Bind(&ExpectResultAndRun<bool>, true, run_loop.QuitClosure()));

run_loop.Run();

@@ -141,6 +143,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,

GetServiceWorkerContext()->RegisterServiceWorker(

embedded_test_server()->GetURL("/"),

embedded_test_server()->GetURL("/service_worker.js"),

+ blink::WebServiceWorkerUpdateViaCache::kImports,

base::Bind(&ExpectResultAndRun<bool>, true, run_loop.QuitClosure()));

run_loop.Run();

@@ -168,6 +171,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,

GetServiceWorkerContext()->RegisterServiceWorker(

embedded_test_server()->GetURL("/"),

embedded_test_server()->GetURL("/service_worker.js"),

+ blink::WebServiceWorkerUpdateViaCache::kImports,

base::Bind(&ExpectResultAndRun<bool>, false, run_loop.QuitClosure()));

run_loop.Run();

}

@@ -677,6 +681,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerNavigationHintTest,

GetServiceWorkerContext()->RegisterServiceWorker(

embedded_test_server()->GetURL("/scope/"),

embedded_test_server()->GetURL("/sw.js"),

+ blink::WebServiceWorkerUpdateViaCache::kImports,

base::Bind(&ExpectResultAndRun<bool>, true, run_loop.QuitClosure()));

run_loop.Run();

RunNavigationHintTest("/scope/",