chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc - Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts

Patch Set: change useCache to updateViaCache Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt ('K') | « chrome/browser/DEPS ('k') | chrome/browser/chrome_service_worker_browsertest.cc » ('j') | content/browser/service_worker/link_header_support.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

index 8725d7ff0162e89ecb6ed5bb2fccaef94acc377a..caf8153b616b0f5cb52765273fbb7ceb8dcc6168 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc

@@ -225,7 +225,8 @@ class AddToHomescreenDataFetcherTest : public ChromeRenderViewHostTestHarness {

void RegisterServiceWorker(const GURL& url) {

base::RunLoop run_loop;

embedded_worker_test_helper_->context()->RegisterServiceWorker(

- url, GURL(url.spec() + "/service_worker.js"), nullptr,

+ GURL(url.spec() + "/service_worker.js"),

+ content::ServiceWorkerRegistrationOptions(url), nullptr,

base::Bind(&AddToHomescreenDataFetcherTest::OnServiceWorkerRegistered,

base::Unretained(this), run_loop.QuitClosure()));

}