Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: content/browser/service_worker/service_worker_registration.h

Issue 2771823002: Implement updateViaCache flag and no-cache by default for main service worker scripts
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_registration.h
diff --git a/content/browser/service_worker/service_worker_registration.h b/content/browser/service_worker/service_worker_registration.h
index bdf2c4026ba5cd98a0ab9e729c91335ca9017eeb..ff8011c3a9d61c2aced72088aad5d4fe2eb82926 100644
--- a/content/browser/service_worker/service_worker_registration.h
+++ b/content/browser/service_worker/service_worker_registration.h
@@ -51,11 +51,13 @@ class CONTENT_EXPORT ServiceWorkerRegistration
};
ServiceWorkerRegistration(const GURL& pattern,
+ bool use_cache,
int64_t registration_id,
base::WeakPtr<ServiceWorkerContextCore> context);
int64_t id() const { return registration_id_; }
const GURL& pattern() const { return pattern_; }
+ bool use_cache() const { return use_cache_; }
bool is_deleted() const { return is_deleted_; }
void set_is_deleted(bool deleted) { is_deleted_ = deleted; }
@@ -194,6 +196,7 @@ class CONTENT_EXPORT ServiceWorkerRegistration
ServiceWorkerStatusCode status);
const GURL pattern_;
+ const bool use_cache_;
nhiroki 2017/03/28 06:49:51 Why don't you use ServiceWorkerRegistrationOptions
yuryu 2017/03/28 07:07:02 I thought it would make sense to align the type wi
nhiroki 2017/03/28 07:21:50 IMO, we don't have to make the implementation comp
yuryu 2017/07/20 10:15:12 Acknowledged.
const int64_t registration_id_;
bool is_deleted_;
bool is_uninstalling_;

Powered by Google App Engine
This is Rietveld 408576698