Implement updateViaCache flag and no-cache by default for main service worker scripts

content/browser/service_worker/service_worker_registration.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 33 matching lines @@
     virtual void OnRegistrationFailed(
         ServiceWorkerRegistration* registration) {}
     virtual void OnRegistrationFinishedUninstalling(
         ServiceWorkerRegistration* registration) {}
     virtual void OnUpdateFound(
         ServiceWorkerRegistration* registration) {}
     virtual void OnSkippedWaiting(ServiceWorkerRegistration* registation) {}
   };
 
   ServiceWorkerRegistration(const GURL& pattern,
+                            bool use_cache,
                             int64_t registration_id,
                             base::WeakPtr<ServiceWorkerContextCore> context);
 
   int64_t id() const { return registration_id_; }
   const GURL& pattern() const { return pattern_; }
+  bool use_cache() const { return use_cache_; }
 
   bool is_deleted() const { return is_deleted_; }
   void set_is_deleted(bool deleted) { is_deleted_ = deleted; }
 
   bool is_uninstalling() const { return is_uninstalling_; }
 
   void set_is_uninstalled(bool uninstalled) { is_uninstalled_ = uninstalled; }
   bool is_uninstalled() const { return is_uninstalled_; }
 
   int64_t resources_total_size_bytes() const {
@@ skipping 118 matching lines @@
   void OnDeleteFinished(ServiceWorkerStatusCode status);
 
   // This method corresponds to the [[ClearRegistration]] algorithm.
   void Clear();
 
   void OnRestoreFinished(const StatusCallback& callback,
                          scoped_refptr<ServiceWorkerVersion> version,
                          ServiceWorkerStatusCode status);
 
   const GURL pattern_;
+  const bool use_cache_;

[nhiroki, 2017/03/28 06:49:51]

Why don't you use ServiceWorkerRegistrationOptions::UseCache?

[yuryu, 2017/03/28 07:07:02]

I thought it would make sense to align the type with ServiceWorkerRegistration
in the spec
https://w3c.github.io/ServiceWorker/#serviceworkerregistration-interface

If this alignment is not necessary, I'll change it to
ServiceWorkerRegistrationOptions::UseCache.

[nhiroki, 2017/03/28 07:21:50]

IMO, we don't have to make the implementation completely aligned with the spec
if the implementation is much clearer and the user-facing behavior is not
changed.

[yuryu, 2017/07/20 10:15:12]

Acknowledged.

   const int64_t registration_id_;
   bool is_deleted_;
   bool is_uninstalling_;
   bool is_uninstalled_;
   bool should_activate_when_ready_;
   NavigationPreloadState navigation_preload_state_;
   base::Time last_update_check_;
   int64_t resources_total_size_bytes_;
 
   // This registration is the primary owner of these versions.
   scoped_refptr<ServiceWorkerVersion> active_version_;
   scoped_refptr<ServiceWorkerVersion> waiting_version_;
   scoped_refptr<ServiceWorkerVersion> installing_version_;
 
   base::ObserverList<Listener> listeners_;
   std::vector<base::Closure> registration_finished_callbacks_;
   base::WeakPtr<ServiceWorkerContextCore> context_;
   scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerRegistration);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_REGISTRATION_H_