Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 2771813002: RemoteSuggestionsFetcher: Remove ChromeReader integration (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
Reviewers:
sfiera
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

RemoteSuggestionsFetcher: Remove ChromeReader integration BUG=704535 Review-Url: https://codereview.chromium.org/2771813002 Cr-Commit-Position: refs/heads/master@{#459082} Committed: https://chromium.googlesource.com/chromium/src/+/a57f51e648fdeaf10ad5ef9bcef08c4794c4a42a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -320 lines) Patch
M components/ntp_snippets/ntp_snippets_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/ntp_snippets/ntp_snippets_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/json_request.h View 4 chunks +0 lines, -9 lines 0 comments Download
M components/ntp_snippets/remote/json_request.cc View 3 chunks +31 lines, -79 lines 0 comments Download
M components/ntp_snippets/remote/json_request_unittest.cc View 7 chunks +5 lines, -74 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher.cc View 7 chunks +42 lines, -85 lines 0 comments Download
M components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc View 16 chunks +22 lines, -68 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Marc Treib
PTAL!
3 years, 9 months ago (2017-03-23 14:28:13 UTC) #4
sfiera
LGTM
3 years, 9 months ago (2017-03-23 14:42:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771813002/1
3 years, 9 months ago (2017-03-23 14:43:57 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 14:48:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a57f51e648fdeaf10ad5ef9bcef0...

Powered by Google App Engine
This is Rietveld 408576698