Create a sub direcory for translate custom views.

Create a sub directory for translate custom views.
New UI structure will look like as below:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887
Review-Url: https://codereview.chromium.org/2771763002
Cr-Commit-Position: refs/heads/master@{#459312}
Committed: https://chromium.googlesource.com/chromium/src/+/a44c7e0a9e8241baf4dd9db11a8527f6826be58b

[Leo, 2017-03-23 06:48:58]

Description was changed from

==========
Create a sub direcory for translate custom views.
New UI structure will look like:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java

BUG=703887
==========

to

==========
Create a sub directory for translate custom views.
New UI structure will look like later:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887
==========

[Leo, 2017-03-23 06:48:58]

googleo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Leo, 2017-03-23 06:49:39]

Description was changed from

==========
Create a sub directory for translate custom views.
New UI structure will look like later:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887
==========

to

==========
Create a sub directory for translate custom views.
New UI structure will look like as below:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887
==========

[gone, 2017-03-23 18:03:31]

Pro-tip:

I don't get emails about this unless you "Publish+Mail Comments and set me as a
reviewer there.  Editing the issue and then adding me doesn't send any emails.

[gone, 2017-03-23 18:11:25]

lgtm

Still haven't heard from UX about what to do about the layout.  Might have to
land some skeleton of the compact infobar layout if they don't start doing so. 
Maybe with a picture of their heads on every infobar:
https://goto.google.com/zqirj

https://codereview.chromium.org/2771763002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/infobar_translate_compact_content.xml
(right):

https://codereview.chromium.org/2771763002/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/infobar_translate_compact_content.xml:27:
android:contentDescription="@null"
Add this:

android:background="?attr/selectableItemBackground"

Might make it so the button ripples when you long press.

[Leo, 2017-03-23 22:54:23]

On 2017/03/23 18:03:31, dfalcantara (load balance plz) wrote:
> Pro-tip:
> 
> I don't get emails about this unless you "Publish+Mail Comments and set me as
a
> reviewer there.  Editing the issue and then adding me doesn't send any emails.

Sorry for that. Will do next time.

[Leo, 2017-03-23 22:54:25]

On 2017/03/23 18:03:31, dfalcantara (load balance plz) wrote:
> Pro-tip:
> 
> I don't get emails about this unless you "Publish+Mail Comments and set me as
a
> reviewer there.  Editing the issue and then adding me doesn't send any emails.

Sorry for that. Will do next time.

[Leo, 2017-03-23 22:57:33]

On 2017/03/23 18:11:25, dfalcantara (load balance plz) wrote:
> lgtm
> 
> Still haven't heard from UX about what to do about the layout.  Might have to
> land some skeleton of the compact infobar layout if they don't start doing so.

> Maybe with a picture of their heads on every infobar:
> https://goto.google.com/zqirj 


Good idea!!!


>
https://codereview.chromium.org/2771763002/diff/20001/chrome/android/java/res...
> File chrome/android/java/res/layout/infobar_translate_compact_content.xml
> (right):
> 
>
https://codereview.chromium.org/2771763002/diff/20001/chrome/android/java/res...
> chrome/android/java/res/layout/infobar_translate_compact_content.xml:27:
> android:contentDescription="@null"
> Add this:
> 
> android:background="?attr/selectableItemBackground"
> 
> Might make it so the button ripples when you long press.

DONE! Thanks

[Leo, 2017-03-23 22:59:52]

The CQ bit was checked by googleo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 23:00:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 00:09:22]

Dry run: This issue passed the CQ dry run.

[Leo, 2017-03-24 00:53:42]

The CQ bit was checked by googleo@chromium.org

[Leo, 2017-03-24 00:53:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2771763002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-03-24 00:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 00:58:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490316822886050,
"parent_rev": "3c14c4246f4ef9ec878d8fddecf7d9684c2fb33c", "commit_rev":
"a44c7e0a9e8241baf4dd9db11a8527f6826be58b"}

[commit-bot: I haz the power, 2017-03-24 00:59:33]

Description was changed from

==========
Create a sub directory for translate custom views.
New UI structure will look like as below:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887
==========

to

==========
Create a sub directory for translate custom views.
New UI structure will look like as below:

TransateCompactInfobar.java
translate
  |-- TranslateTabLayout.java
  |-- TranslateTabContent.java
  |-- OverflowMenu.java
  |-- ...


Tested by a hacking https://codereview.chromium.org/2772643003/
Screenshot:
https://screenshot.googleplex.com/GnDdkaxnNN0

BUG=703887

Review-Url: https://codereview.chromium.org/2771763002
Cr-Commit-Position: refs/heads/master@{#459312}
Committed:
https://chromium.googlesource.com/chromium/src/+/a44c7e0a9e8241baf4dd9db11a85...
==========

[commit-bot: I haz the power, 2017-03-24 00:59:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a44c7e0a9e8241baf4dd9db11a85...