Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2771753005: Simplify Editor::Command::value(). (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Editor::Command::value(). Move valueNull()-specific code from Editor::Command::value() to valueNull(), and rename valueNull() to valueStateOrNull(), valueNo() to valueEmpty(). This CL has no behavior changes. Review-Url: https://codereview.chromium.org/2771753005 Cr-Commit-Position: refs/heads/master@{#459377} Committed: https://chromium.googlesource.com/chromium/src/+/8e52305016cd7750c6d168e9d995345928de3c02

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -166 lines) Patch
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 6 chunks +189 lines, -166 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tkent
yosin@, would you review this please?
3 years, 9 months ago (2017-03-24 04:37:30 UTC) #8
yosin_UTC9
lgtm It is nice that value of commands are descriptive!
3 years, 9 months ago (2017-03-24 04:39:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771753005/1
3 years, 9 months ago (2017-03-24 07:10:29 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 07:16:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e52305016cd7750c6d168e9d995...

Powered by Google App Engine
This is Rietveld 408576698