Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: courgette/program_detector.cc

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)
Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « courgette/instruction_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: courgette/program_detector.cc
diff --git a/courgette/program_detector.cc b/courgette/program_detector.cc
index f024a36462f0671d2f25ddd0d034fe4748ac77e8..d67dc23fae88d66082beafc33887355473ccdac9 100644
--- a/courgette/program_detector.cc
+++ b/courgette/program_detector.cc
@@ -6,7 +6,6 @@
#include <utility>
-#include "base/memory/ptr_util.h"
#include "courgette/assembly_program.h"
#include "courgette/disassembler.h"
#include "courgette/disassembler_elf_32_arm.h"
@@ -77,10 +76,8 @@ Status ParseDetectedExecutable(const uint8_t* buffer,
if (!disassembler)
return C_INPUT_NOT_RECOGNIZED;
- auto program = base::MakeUnique<AssemblyProgram>(disassembler->kind(),
- disassembler->image_base());
-
- if (!disassembler->Disassemble(program.get()))
+ std::unique_ptr<AssemblyProgram> program = disassembler->Disassemble();
+ if (!program.get())
return C_DISASSEMBLY_FAILED;
*output = std::move(program);
« no previous file with comments | « courgette/instruction_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698