Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: courgette/program_detector.cc

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)
Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « courgette/instruction_utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "courgette/program_detector.h" 5 #include "courgette/program_detector.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h"
10 #include "courgette/assembly_program.h" 9 #include "courgette/assembly_program.h"
11 #include "courgette/disassembler.h" 10 #include "courgette/disassembler.h"
12 #include "courgette/disassembler_elf_32_arm.h" 11 #include "courgette/disassembler_elf_32_arm.h"
13 #include "courgette/disassembler_elf_32_x86.h" 12 #include "courgette/disassembler_elf_32_x86.h"
14 #include "courgette/disassembler_win32_x64.h" 13 #include "courgette/disassembler_win32_x64.h"
15 #include "courgette/disassembler_win32_x86.h" 14 #include "courgette/disassembler_win32_x86.h"
16 15
17 namespace courgette { 16 namespace courgette {
18 17
19 namespace { 18 namespace {
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 Status ParseDetectedExecutable(const uint8_t* buffer, 69 Status ParseDetectedExecutable(const uint8_t* buffer,
71 size_t length, 70 size_t length,
72 std::unique_ptr<AssemblyProgram>* output) { 71 std::unique_ptr<AssemblyProgram>* output) {
73 output->reset(); 72 output->reset();
74 73
75 std::unique_ptr<Disassembler> disassembler( 74 std::unique_ptr<Disassembler> disassembler(
76 DetectDisassembler(buffer, length)); 75 DetectDisassembler(buffer, length));
77 if (!disassembler) 76 if (!disassembler)
78 return C_INPUT_NOT_RECOGNIZED; 77 return C_INPUT_NOT_RECOGNIZED;
79 78
80 auto program = base::MakeUnique<AssemblyProgram>(disassembler->kind(), 79 std::unique_ptr<AssemblyProgram> program = disassembler->Disassemble();
81 disassembler->image_base()); 80 if (!program.get())
82
83 if (!disassembler->Disassemble(program.get()))
84 return C_DISASSEMBLY_FAILED; 81 return C_DISASSEMBLY_FAILED;
85 82
86 *output = std::move(program); 83 *output = std::move(program);
87 return C_OK; 84 return C_OK;
88 } 85 }
89 86
90 } // namespace courgette 87 } // namespace courgette
OLDNEW
« no previous file with comments | « courgette/instruction_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698