courgette/disassembler_elf_32_arm.cc - Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler_elf_32_arm.cc

Issue 2771753004: [Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there. (Closed)

Patch Set: Fix signed/unsigned comparison issue in test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler_elf_32_arm.cc

diff --git a/courgette/disassembler_elf_32_arm.cc b/courgette/disassembler_elf_32_arm.cc

index 0d9f340b70f79a34b289e4a09c8f8d898ffdbc33..bbd52f04544f7418350a6ff53286875a700ba602 100644

--- a/courgette/disassembler_elf_32_arm.cc

+++ b/courgette/disassembler_elf_32_arm.cc

@@ -366,7 +366,7 @@ CheckBool DisassemblerElf32ARM::ParseRelocationSection(

match = false;

if (!abs32_locations_.empty()) {

- std::vector<RVA>::iterator reloc_iter = abs32_locations_.begin();

+ std::vector<RVA>::const_iterator reloc_iter = abs32_locations_.begin();

for (uint32_t i = 0; i < section_relocs_count; ++i) {

if (section_relocs_iter->r_offset == *reloc_iter)

« no previous file with comments | « courgette/disassembler_elf_32.cc ('k') | courgette/disassembler_elf_32_x86.cc » ('j') | no next file with comments »