[Courgette] Refactor: Unify Disassembler::Disassemble() and instantiate AssemblyProgram there.

courgette/disassembler_elf_32_arm.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_elf_32_arm.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 348 matching lines @@
   const Elf32_Rel* section_relocs_iter = reinterpret_cast<const Elf32_Rel*>(
       FileOffsetToPointer(section_header->sh_offset));
 
   uint32_t section_relocs_count =
       section_header->sh_size / section_header->sh_entsize;
 
   if (abs32_locations_.size() > section_relocs_count)
     match = false;
 
   if (!abs32_locations_.empty()) {
-    std::vector<RVA>::iterator reloc_iter = abs32_locations_.begin();
+    std::vector<RVA>::const_iterator reloc_iter = abs32_locations_.begin();
 
     for (uint32_t i = 0; i < section_relocs_count; ++i) {
       if (section_relocs_iter->r_offset == *reloc_iter)
         break;
 
       if (!ParseSimpleRegion(file_offset, file_offset + sizeof(Elf32_Rel),
                              receptor)) {
         return false;
       }
 
@@ skipping 139 matching lines @@
       // Move 2 bytes at a time, but track 32-bit boundaries
       p += 2;
       on_32bit = ((on_32bit + 1) % 2) != 0;
     }
   }
 
   return true;
 }
 
 }  // namespace courgette