Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2771733002: X11: Use XC_hand2 instead of XC_hand1 (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

X11: Use XC_hand2 instead of XC_hand1 This CL fixes a regression introduced in [1], where one instance of XC_hand2 was accidentally changed to XC_hand1. This made the cursor right-pointing instead of left-pointing [2]. [1] https://codereview.chromium.org/2504743002/ [2] https://tronche.com/gui/x/xlib/appendix/b/ BUG=703982 R=derat@chromium.org Review-Url: https://codereview.chromium.org/2771733002 Cr-Commit-Position: refs/heads/master@{#458963} Committed: https://chromium.googlesource.com/chromium/src/+/f5067d43c3ea45f96b7716c1d4f42ef27d982e81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/cursor/cursor_loader_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom (Use chromium acct)
derat@ ptal
3 years, 9 months ago (2017-03-22 23:43:09 UTC) #2
Daniel Erat
lgtm hah, i noticed this on a home machine and was briefly confused. it was ...
3 years, 9 months ago (2017-03-23 00:19:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771733002/1
3 years, 9 months ago (2017-03-23 00:50:16 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 00:59:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5067d43c3ea45f96b7716c1d4f4...

Powered by Google App Engine
This is Rietveld 408576698