Shape Detection: initialize all mojo::Bitmap fields

Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message: VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build with the demos
- https://codepen.io/miguelao/full/ygxVqg 
- https://codepen.io/miguelao/full/wgrYjZ 
- https://codepen.io/miguelao/full/ORYbbm

Interestingly, content_browsertests are passing both 
in the bots and locally.  Perhaps a different deserialization
validation logic is used in different cases?

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2771703002
Cr-Commit-Position: refs/heads/master@{#458960}
Committed: https://chromium.googlesource.com/chromium/src/+/f59872240739c45017e90aa1be20548177d6df59

[mcasas, 2017-03-22 22:56:48]

Description was changed from

==========
Shape Detection: initialize all mojo::Bitmap fields

all mojo::bitmap fields

otherwise
[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

BUG=665488
==========

to

==========
Shape Detection: initialize all mojo::Bitmap fields

all mojo::bitmap fields

otherwise
[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-22 22:58:34]

Description was changed from

==========
Shape Detection: initialize all mojo::Bitmap fields

all mojo::bitmap fields

otherwise
[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: initialize all mojo::Bitmap fields

all mojo::bitmap fields

otherwise
[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

content_browsertests are passing both in the bots and 
locally.

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-22 23:01:00]

Description was changed from

==========
Shape Detection: initialize all mojo::Bitmap fields

all mojo::bitmap fields

otherwise
[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

content_browsertests are passing both in the bots and 
locally.

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build.  

Interestingly, content_browsertests are passing both 
in the bots and locally.

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-22 23:02:07]

Description was changed from

==========
Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build.  

Interestingly, content_browsertests are passing both 
in the bots and locally.

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build with the demos
- https://codepen.io/miguelao/full/ygxVqg 
- https://codepen.io/miguelao/full/wgrYjZ 
- https://codepen.io/miguelao/full/ORYbbm

Interestingly, content_browsertests are passing both 
in the bots and locally.  Perhaps a different deserialization
validation logic is used in different cases?

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-22 23:02:11]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-03-22 23:02:29]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2017-03-22 23:03:11]

mcasas@chromium.org changed reviewers:
+ rockot@chromium.org

[mcasas, 2017-03-22 23:03:11]

rockot@   tiny cleanup CL, PTAL

[commit-bot: I haz the power, 2017-03-22 23:03:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-03-22 23:36:06]

lgtm

[commit-bot: I haz the power, 2017-03-22 23:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:36:36]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mcasas, 2017-03-22 23:44:40]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 00:51:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490226280834080,
"parent_rev": "f89e04046aaac44ecad27056fb856c3d6e37370f", "commit_rev":
"f59872240739c45017e90aa1be20548177d6df59"}

[commit-bot: I haz the power, 2017-03-23 00:53:01]

Description was changed from

==========
Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build with the demos
- https://codepen.io/miguelao/full/ygxVqg 
- https://codepen.io/miguelao/full/wgrYjZ 
- https://codepen.io/miguelao/full/ORYbbm

Interestingly, content_browsertests are passing both 
in the bots and locally.  Perhaps a different deserialization
validation logic is used in different cases?

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: initialize all mojo::Bitmap fields

This CL initializes all the fields of the newly allocated
skia::mojom::blink::Bitmap before sending it over mojo,
otherwise I get 

[...:ERROR:validation_errors.cc(87)] Invalid message:
VALIDATION_ERROR_DESERIALIZATION_FAILED

when running a Chromium build with the demos
- https://codepen.io/miguelao/full/ygxVqg 
- https://codepen.io/miguelao/full/wgrYjZ 
- https://codepen.io/miguelao/full/ORYbbm

Interestingly, content_browsertests are passing both 
in the bots and locally.  Perhaps a different deserialization
validation logic is used in different cases?

BUG=665488
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2771703002
Cr-Commit-Position: refs/heads/master@{#458960}
Committed:
https://chromium.googlesource.com/chromium/src/+/f59872240739c45017e90aa1be20...
==========

[commit-bot: I haz the power, 2017-03-23 00:53:02]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f59872240739c45017e90aa1be20...

[junwei, 2017-03-23 00:54:36]

Thank you so much for all the help that you had given me, and say sorry about
multiple CLs.