url/gurl.h - Issue 2771643002: Enable noexcept on Windows, use for a few move constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.h

Issue 2771643002: Enable noexcept on Windows, use for a few move constructors. (Closed)

Patch Set: jni Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: url/gurl.h

diff --git a/url/gurl.h b/url/gurl.h

index 4cbd84656f989a63ff54ccf50fa3b3aa484c658c..74efbb5021e67515fa14738bd315a6338d344daf 100644

--- a/url/gurl.h

+++ b/url/gurl.h

@@ -54,7 +54,7 @@ class URL_EXPORT GURL {

// Copy construction is relatively inexpensive, with most of the time going

// to reallocating the string. It does not re-parse.

GURL(const GURL& other);

- GURL(GURL&& other);

+ GURL(GURL&& other) noexcept;

// The strings to this contructor should be UTF-8 / UTF-16.

explicit GURL(base::StringPiece url_string);