base/containers/flat_map.h - Issue 2771643002: Enable noexcept on Windows, use for a few move constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/containers/flat_map.h

Issue 2771643002: Enable noexcept on Windows, use for a few move constructors. (Closed)

Patch Set: jni Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/containers/flat_map.h

diff --git a/base/containers/flat_map.h b/base/containers/flat_map.h

index 8ae5a50e357fcc9615dab6171037b1aedef0a969..5e8a612f5470021ef508cfe679f8febed290dd23 100644

--- a/base/containers/flat_map.h

+++ b/base/containers/flat_map.h

@@ -145,7 +145,7 @@ class flat_map : public ::base::internal::flat_tree<

const Compare& comp = Compare());

flat_map(const flat_map&);

- flat_map(flat_map&&);

+ flat_map(flat_map&&) noexcept;

// Not stable in the presence of duplicates in the initializer list.

flat_map(std::initializer_list<value_type> ilist,

@@ -204,7 +204,7 @@ template <class Key, class Mapped, class Compare>

flat_map<Key, Mapped, Compare>::flat_map(const flat_map&) = default;

template <class Key, class Mapped, class Compare>

-flat_map<Key, Mapped, Compare>::flat_map(flat_map&&) = default;

+flat_map<Key, Mapped, Compare>::flat_map(flat_map&&) noexcept = default;

brucedawson 2017/03/22 21:39:05 That reads weird, as if you are setting noexcept t

template <class Key, class Mapped, class Compare>

flat_map<Key, Mapped, Compare>::flat_map(

« no previous file with comments | « base/android/jni_weak_ref.cc ('k') | base/containers/flat_tree.h » ('j') | no next file with comments »