base/android/jni_weak_ref.cc - Issue 2771643002: Enable noexcept on Windows, use for a few move constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_weak_ref.cc

Issue 2771643002: Enable noexcept on Windows, use for a few move constructors. (Closed)

Patch Set: jni Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/jni_weak_ref.cc

diff --git a/base/android/jni_weak_ref.cc b/base/android/jni_weak_ref.cc

index fe7ea2e5d3618204eabe7f040d140922b9dc7b34..88efa723e5fd61775598ee3e260b3881c387cc99 100644

--- a/base/android/jni_weak_ref.cc

+++ b/base/android/jni_weak_ref.cc

@@ -19,7 +19,8 @@ JavaObjectWeakGlobalRef::JavaObjectWeakGlobalRef(

Assign(orig);

}

-JavaObjectWeakGlobalRef::JavaObjectWeakGlobalRef(JavaObjectWeakGlobalRef&& orig)

+JavaObjectWeakGlobalRef::JavaObjectWeakGlobalRef(

+ JavaObjectWeakGlobalRef&& orig) noexcept

: obj_(orig.obj_) {

orig.obj_ = nullptr;

}