Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2771623003: DevTools: add tests to fixate javascript outline behavior (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add tests to fixate javascript outline behavior This patch adds tests to fixate javascript outline behavior. It tests: - outline for different functions, including async and generators - outline for syntax-broken javascript - outline for classes (which doesn't work for now) - outline for arrow functions BUG=438203 R=dgozman Review-Url: https://codereview.chromium.org/2771623003 Cr-Commit-Position: refs/heads/master@{#459265} Committed: https://chromium.googlesource.com/chromium/src/+/e5d18d9dbefde2956d137ef766faec573724ca46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/sources-test.js View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-1.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-1-expected.txt View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-2.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-2-expected.txt View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-3.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-3-expected.txt View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4.html View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/sources/outline-javascript-4-expected.txt View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-23 01:54:54 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-23 22:00:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771623003/1
3 years, 9 months ago (2017-03-23 22:51:43 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 23:01:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e5d18d9dbefde2956d137ef766fa...

Powered by Google App Engine
This is Rietveld 408576698