Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2771623002: Bootstrapping: Display meaningful enrollment error message on Slave device. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 9 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Bootstrapping: Display meaningful enrollment error message on Slave device. Enrollment failure is a blackbox right now. We should display meaningful information to the user why enrollment failed and how to recover. BUG=695235 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2771623002 Cr-Commit-Position: refs/heads/master@{#459129} Committed: https://chromium.googlesource.com/chromium/src/+/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
xdai1
achuith@, could you help review this CL please? Thanks!
3 years, 9 months ago (2017-03-22 20:51:02 UTC) #3
xdai1
FYI: please see the current screenshot for enrollment error page as an example: https://drive.google.com/a/google.com/file/d/0B4R9nvLdzmC9dHFyVnNyUzlsVUE/view?usp=sharing
3 years, 9 months ago (2017-03-22 21:03:40 UTC) #6
achuithb
lgtm
3 years, 9 months ago (2017-03-23 00:22:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2771623002/1
3 years, 9 months ago (2017-03-23 17:27:06 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 17:36:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6c5fb0be53c19f15c3f134a8d2f...

Powered by Google App Engine
This is Rietveld 408576698